test: add regression tests for 44 closed GitHub issues#414
Merged
Conversation
Add 52 test cases covering 44 closed GitHub issues across 10 categories: - Circular reference handling (9 tests) - Root-level $ref resolution (8 tests) - Bundle operations (4 tests) - Dereference operations (4 tests) - JSON Pointer handling (5 tests) - External references (2 tests) - Error handling (2 tests) - And 6 more categories Tests validate the current behavior of fixed issues and document expected behavior for issues that remain open. Includes 12 fixture files for testing external file resolution and complex schemas. All tests pass. Full test suite: 350 tests passing, 6 skipped.
Pull Request Test Coverage Report for Build 22527068386Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 52 comprehensive regression tests covering 44 historical closed GitHub issues across 10 categories including circular references, root-level $refs, bundle operations, dereference operations, JSON Pointer handling, external references, error handling, custom resolvers, OpenAPI patterns, and miscellaneous edge cases.
Test Coverage
$reffails withTypeError: Converting circular structure to JSON#382, Recursive (Circular) model $ref doesn't dereference unless wrapped in anyOf (sibling keys alongside $ref keys) #370, Dereferencing behavior on OpenAPI 3.1 schemas #365, bundle() creates a invalid $ref #338, References to existing but null values fail as missing #310, Does not resolve a top level $ref to a definition when using dereference #279, Immediately circular schema causes a maximum call stack trace exception #271, and many moreVerification
All 350 existing tests pass, 6 pre-existing skips remain. TypeScript and ESLint checks pass with no issues.