chore: replace AlloyDBFeature with static JSON config#645
Merged
Conversation
mpeddada1
reviewed
May 28, 2025
9eede2e to
b91b021
Compare
nancynh
reviewed
May 28, 2025
8034a53 to
b8bfada
Compare
f0ca382 to
8df2ff9
Compare
This commit removes the references to the GraalVM SDK and also removes the AlloyDBFeature class. Instead, the commit uses JSON to configure the native image. This resolves a few problems: - The code wasn't consuming the latest GraalVM SDK from the parent POM - The presence of newer GraalVM breaks tests on Java 8. - The native-image META-INFO directory wasn't matching groupId/artifactId for the Java Connector. Now, with this commit, there is no need to reference GraalVM SDK at all. And there is no conflict with Java 8 tests.
8df2ff9 to
f0712ea
Compare
Member
Author
|
@nancynh @mpeddada1 this is ready for review. The successful GraalVM test build can be found here: https://github.com/GoogleCloudPlatform/alloydb-java-connector/actions/runs/15311240508/job/43076160971. I've since restored the GraalVM tests to nightly and updated the description to cover what we've done here. Thanks again to @mpeddada1 for the suggestion to migrate to static config. |
nancynh
approved these changes
May 28, 2025
Collaborator
nancynh
left a comment
There was a problem hiding this comment.
Amazing! Great work, and thank you!
mpeddada1
approved these changes
May 28, 2025
enocom
added a commit
that referenced
this pull request
May 29, 2025
This commit cleans up additional leftovers following #645. In particular: - Rename the CI workflow from graalvm17 to just graalvm - Remove unnecessary dependency management config and build config for the GraalVM profile, and instead use the configuration from the parent POM. - Remove unnecessary values from reflect config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the references to the GraalVM SDK and also removes
the AlloyDBFeature class. Instead, the commit uses JSON to configure the
native image.
This resolves a few problems:
groupId/artifactId for the Java Connector.
Now, with this commit, there is no need to reference GraalVM SDK at all.
And there is no conflict with Java 8 tests. In addition, there's no need to
keep the native-image.properties file either.
Note that we're using reflect-config.json, the format for GraalVM for JDK 21 1.
The file name and format changes to reachability-metadata.json for JDK 24 2.
For now, it seems other Cloud SDK libraries are using the JDK 21 format, so we'll
stick to that.