Skip to content

feat(secretmanager): Add filter and cmek related samples#3292

Open
khilan-crest wants to merge 12 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_filter_cmek_samples
Open

feat(secretmanager): Add filter and cmek related samples#3292
khilan-crest wants to merge 12 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_filter_cmek_samples

Conversation

@khilan-crest
Copy link

@khilan-crest khilan-crest commented Jan 22, 2026

Add filter and cmek related samples

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 22, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a suite of new C# samples for Google Cloud Secret Manager. These additions aim to broaden the coverage of common Secret Manager operations, specifically focusing on the management of secret metadata like annotations and labels, advanced listing capabilities using filters, and the creation of secrets secured with Customer-Managed Encryption Keys (CMEK). The new samples provide practical, ready-to-use code examples for developers interacting with the Secret Manager API.

Highlights

  • Secret Annotation and Label Management: New samples have been added for deleting annotations and labels from both global and regional secrets, as well as editing labels on global secrets.
  • Secret Listing with Filters: A new sample demonstrates how to list secrets using a filter, allowing for more targeted retrieval of secrets based on criteria like labels.
  • Customer-Managed Encryption Keys (CMEK) for Secrets: Samples are now available for creating secrets with Customer-Managed Encryption Keys (CMEK), covering both global and regional secret configurations to enhance data security.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 22, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new samples and tests for Secret Manager, focusing on features like filtering, CMEK, and managing annotations/labels. The additions are valuable, but I've identified a few areas for improvement. A recurring issue in the new tests is the lack of guaranteed resource cleanup, which could lead to leaked secrets in the test environment. I've suggested using try...finally blocks to make cleanup more robust. Additionally, some samples manually construct resource name strings, which is less safe and inconsistent with other samples that use strongly-typed resource name classes. Finally, one sample contains a misleading log message that could confuse users. My comments provide specific suggestions to address these points.

@khilan-crest khilan-crest marked this pull request as ready for review January 30, 2026 06:14
@khilan-crest khilan-crest requested review from a team as code owners January 30, 2026 06:14
@snippet-bot
Copy link

snippet-bot bot commented Jan 30, 2026

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@underscoreanuj underscoreanuj

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khilan-crest @underscoreanuj @cy-yun