Merged
Conversation
kurtisvg
suggested changes
Aug 27, 2018
Contributor
kurtisvg
left a comment
There was a problem hiding this comment.
s/Google Inc/Google LLC/
| @@ -0,0 +1,175 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
Contributor
Author
There was a problem hiding this comment.
I'm getting a style issue with LLC, is it supposed to be LLC.?
Contributor
There was a problem hiding this comment.
No, but you need to update the parent's in the pom.xml so it's using the updated checkstyle (sorry I missed this in the initial review):
<!--
The parent pom defines common style checks and testing strategies for our samples.
Removing or replacing it should not affect the execution of the samples in anyway.
-->
<parent>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.9</version>
</parent>
| @@ -0,0 +1,134 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
Contributor
Author
|
Not sure what this error is: |
Contributor
Author
|
Updated some more region tags. PTAL |
kurtisvg
approved these changes
Aug 28, 2018
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Clean copy of Dialogflow samples, need to update pom.xml to work with java-docs-samples repo * Update files to match GCP Repo's style guides * Update argument parsing * Update Inc. to LLC * Update pom.xml * Add missing region tags for sample tracker
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Clean copy of Dialogflow samples, need to update pom.xml to work with java-docs-samples repo * Update files to match GCP Repo's style guides * Update argument parsing * Update Inc. to LLC * Update pom.xml * Add missing region tags for sample tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving samples from: https://github.com/dialogflow/dialogflow-java-client-v2
To here.