[bug]: Support helm depBuild flags for helm deploys#9808
[bug]: Support helm depBuild flags for helm deploys#9808alphanota merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a614e98 to
80cab18
Compare
|
Hi @vihangm, thanks for this PR. Before we can review this, you have to sign the Contribution License Agreement. Please follow the instructions here to sign the license and re-run the cla check.
|
|
Sorry for the delay here, I am waiting on the authorized signatory to complete the CLA! |
|
@alphanota This is good to go now! |
|
@alphanota It's been almost 2 months since the last release. Any update on future release schedules? I'm waiting for this fix to make it in. |
Related: #8413, #9696
Description
The helm depBuild flags were added in the most recent version of skaffold, but
they are currently only supported when using helm to render and not supported
when using helm to deploy. This ensures that the flags are applied on deploy
too.
User facing changes (remove if N/A)
The flag is already a part of the schema, it was just ignored before this.