The PR looks like it may have gotten some help from a GPT of some kind, which is fine. But make sure it compiles and passes tests on your local laptop or a cluster you have access to before submitting the PR.

failed tests mostly Hypoelasticity

Failed test tests/9EB947DB: 1D -> Hypoelasticity -> 1 Fluid(s) after 3 attempt(s).
Failed test tests/32A3A936: 1D -> Hypoelasticity -> 1 Fluid(s) -> cont_damage after 3 attempt(s).
Failed test tests/AF0BCEE4: 1D -> Hypoelasticity -> 2 Fluid(s) after 3 attempt(s).
Failed test tests/122713AA: 2D -> Hypoelasticity -> 1 Fluid(s) after 3 attempt(s).
Failed test tests/574636EE: 2D -> Hypoelasticity -> 1 Fluid(s) -> cont_damage after 3 attempt(s).
Failed test tests/595705C7: 2D -> Hypoelasticity -> 1 Fluid(s) -> bc=-2 after 3 attempt(s).
Failed test tests/059D137F: 2D -> Hypoelasticity -> 1 Fluid(s) -> Axisymmetric after 3 attempt(s).
Failed test tests/5281BD7B: 2D -> Hypoelasticity -> 2 Fluid(s) after 3 attempt(s).
Failed test tests/7EFBCDAE: 3D -> Hypoelasticity -> 1 Fluid(s) after 3 attempt(s).
Failed test tests/EF3E7C79: 3D -> Hypoelasticity -> 1 Fluid(s) -> cont_damage after 3 attempt(s).
Failed test tests/67A5ECF8: 3D -> Hypoelasticity -> 1 Fluid(s) -> bc=-2 after 3 attempt(s).
Failed test tests/BDD3411B: 3D -> Hypoelasticity -> 2 Fluid(s) after 3 attempt(s).
Failed test tests/DB670E50: 2D -> Axisymmetric -> model_eqns=2 after 3 attempt(s).
Failed test tests/B89B8C70: 2D -> Axisymmetric -> model_eqns=3 after 3 attempt(s).
Failed test tests/FB822062: 2D -> Axisymmetric -> Viscous after 3 attempt(s).
Failed test tests/B3AAC9C8: 2D -> Axisymmetric -> Viscous -> weno_Re_flux after 3 attempt(s).
Failed test tests/27A13E25: 2D -> Axisymmetric -> Viscous -> weno_Re_flux -> weno_avg after 3 attempt(s).
Failed test tests/7E15602E: 2D -> Acoustic Source -> Transducer -> support=6 -> Sine after 3 attempt(s).
Failed test tests/B2CBB9FE: 2D -> Acoustic Source -> Transducer -> support=6 -> Delay after 3 attempt(s).
Failed test tests/7C2FF26F: 2D -> Acoustic Source -> Transducer -> support=6 -> Gaussian after 3 attempt(s).
Failed test tests/3E23CB5D: 2D -> Acoustic Source -> Transducer Array -> support=10 after 3 attempt(s).
Failed test tests/4D95A70E: 1D -> Example -> hypo_2materials after 3 attempt(s).
Failed test tests/3E400FBF: 2D -> Example -> axisym_shockwatercavity after 3 attempt(s).
Failed test tests/91938DCD: 1D -> Example -> impact after 3 attempt(s).
Failed test tests/5505A65C: 2D -> Example -> 5wave_quasi1D after 3 attempt(s).
Failed test tests/B97D4966: 2D -> Example -> phasechange_bubble after 3 attempt(s).
Failed test tests/7A9F4EF4: 2D -> Example -> axisym_shockbubble after 3 attempt(s).
Failed test tests/5505A65C: 2D -> Example -> 5wave_quasi1D after 3 attempt(s).

this is a hard one to refactor. i recommend doing HLL by itself first, which is shorter and involves less physics/edge cases. then if that works you can do HLLC. i already tried this on my own and think it isn't too bad. do things very incrementally and ensure you don't break things along the way.

Sounds good, I will undo the changes to the solvers subroutines and go from there incrementally.

Codecov Report

Attention: Patch coverage is 7.24638% with 64 lines in your changes missing coverage. Please review.

Project coverage is 43.55%. Comparing base (2f8eef1) to head (60c7621).
Report is 3 commits behind head on master.

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   43.47%   43.55%   +0.07%     
==========================================
  Files          68       68              
  Lines       19766    19457     -309     
  Branches     2375     2333      -42     
==========================================
- Hits         8593     8474     -119     
+ Misses       9726     9575     -151     
+ Partials     1447     1408      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I will close the PR in order to break it down into multiple (~4) - easing up debugging, resolving conflicts, and book keeping.