Skip to content

add more walltime for frontier#960

Merged
sbryngelson merged 1 commit intoMFlowCode:masterfrom
sbryngelson:walltime
Jul 20, 2025
Merged

add more walltime for frontier#960
sbryngelson merged 1 commit intoMFlowCode:masterfrom
sbryngelson:walltime

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Jul 20, 2025 •
edited by qodo-code-review bot
Loading

User description

Add more walltime for Frontier?

PR Type

Enhancement

Description

  • Increase walltime limit for Frontier jobs from 2:59:00 to 3:59:00

Diagram Walkthrough

flowchart LR
  A["Frontier Job Submission"] --> B["Walltime: 2:59:00"] 
  B --> C["Walltime: 3:59:00"]
  C --> D["Extended Job Duration"]
Loading

File Walkthrough
Relevant files
Configuration changes
submit.sh
Increase job walltime limit                                                           

.github/workflows/frontier/submit.sh

  • Updated SBATCH walltime parameter from 02:59:00 to 03:59:00
 +1/-1     

Copilot AI review requested due to automatic review settings July 20, 2025 12:26
Copilot AI reviewed Jul 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the walltime allocation for Frontier HPC jobs from approximately 3 hours to 4 hours to provide more execution time for computational jobs.

Key changes:

  • Increased SLURM walltime parameter from 02:59:00 to 03:59:00

.github/workflows/frontier/submit.sh
#SBATCH -N 1 # Number of nodes required
$sbatch_device_opts
#SBATCH -t 02:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -t 03:59:00 # Duration of the job (Ex: 15 mins)
Copy link

Copilot AI Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment '(Ex: 15 mins)' is misleading as it indicates 15 minutes but the actual walltime is set to 3 hours and 59 minutes. The comment should be updated to reflect the actual duration or removed entirely.

Suggested change
#SBATCH -t 03:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -t 03:59:00 # Duration of the job (Ex: 3 hours and 59 minutes)

Copilot uses AI. Check for mistakes.
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jul 20, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jul 20, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Fix misleading duration comment

The comment indicates "15 mins" but the walltime is set to nearly 4 hours.
Update the comment to reflect the actual duration to avoid confusion.

.github/workflows/frontier/submit.sh [36]

-#SBATCH -t 03:59:00                # Duration of the job (Ex: 15 mins)
+#SBATCH -t 03:59:00                # Duration of the job (Ex: 3 hours 59 mins)
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the example duration in the comment is misleading and does not match the actual time value, improving code clarity.

Low
  • More

@codecov
Copy link

codecov bot commented Jul 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.08%. Comparing base (f775131) to head (d970a26).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   44.08%   44.08%           
=======================================
  Files          69       69           
  Lines       19573    19573           
  Branches     2428     2428           
=======================================
  Hits         8628     8628           
  Misses       9444     9444           
  Partials     1501     1501

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit f2ef560 into MFlowCode:master Jul 20, 2025
29 of 33 checks passed
@sbryngelson sbryngelson deleted the walltime branch August 1, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

Review effort 1/5

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbryngelson