left(), right(): Remove NULL from valid 2nd arg types#2966
Open
nafraf wants to merge 3 commits intoRedisGraph:masterfrom
Open
left(), right(): Remove NULL from valid 2nd arg types#2966nafraf wants to merge 3 commits intoRedisGraph:masterfrom
nafraf wants to merge 3 commits intoRedisGraph:masterfrom
Conversation
AviAvni
reviewed
Mar 19, 2023
| types = array_new(SIType, 2); | ||
| array_append(types, (T_STRING | T_NULL)); | ||
| array_append(types, T_INT64 | T_NULL); | ||
| array_append(types, T_INT64); |
Contributor
There was a problem hiding this comment.
now need to fix the function itself
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2966 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 283 283
Lines 28042 28044 +2
=======================================
+ Hits 25334 25336 +2
Misses 2708 2708
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is to solve this small bug:
The reply to the first call states that Null is a valid type for the second parameter, while actually it is not.
Same for
right().When passing Null we should receive
Type mismatch: expected Integer.After applying the patch: