All exercises: Add four new exercises#509
Conversation
|
In case you're wondering, I have gone through the new exercises myself a few times to make sure everything works as intended. I had to deviate from Replit a few times, but I tried keeping it as easy as possible for beginners. |
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because <!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. --> we are replacing Replit exercises with ones from `javascript-exercises`, so we need to do set up for Node.js earlier in the JavaScripts Basics course. ## This PR <!-- A bullet point list of one or more items describing the specific changes. --> * Moves the Installing Node.js lesson so it is right before the Data Types and Conditionals lesson - The Data Types and Conditionals lesson is where we will have new material from `javascript-exercises` ## Issue <!-- If this PR closes an open issue in this repo, replace the XXXXX below with the issue number, e.g. Closes #2013. If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'. --> Related to TheOdinProject/curriculum#29054 ## Additional Information <!-- Any other information about this PR, such as a link to a Discord discussion. --> Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once: **Blockers:** * Need to add the four new exercises to the `javascript-exercises` repo - TheOdinProject/javascript-exercises#509 * Need to update the appropriate lessons within our `curriculum` repo to replace the Replit lessons currently there - TheOdinProject/curriculum#29161 I will link the relevant PRs here in a moment after I create them. ## Pull Request Requirements <!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. --> - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [ ] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [ ] If applicable, this PR includes new or updated automated tests
|
Hey @Eduardo06sp, sorry again for the delay. Theres been a few merge conflicts since this was last looked at. If we can get those sorted, I'll merge this straight away to avoid us having any more conflicts. The new exercises can just sit in this repo until we merge the curriculum change pointing learners to them. |
|
@KevinMulhern I can't see the merge conflicts anymore, are there still any? I just merged the |
There was a problem hiding this comment.
Looking good, no more conflicts 🎉 thanks @Eduardo06sp.
* Add empty files to create outline * Add broken troubleshooting function * Import troubleshooting.js file * Test function to ensure numbers are added together * Describe exercise two * Test result for troubleshooting function * Add solution * Add empty files to create outline * Add broken numberChecker function * Export numberChecker function * Verify proper return value for numbers greater than or equal to ten * Verify proper return value for numbers less than ten * Add solution * Skip tests after the first one * Describe exercise three * Add empty files to create outline * Add math variables for the exercise * Verify that math-related variables are returning correct answers * Add solution * Add tests for solution * Describe exercise * Add comment to describe answer already given * Add empty files to create outline * Add example problem * Verify that example problem contains correct variables * Add boilerplate code required to begin exercise * Add progressive tests for exercise * Describe exercise * Adjust excessive indentation * Add hint using comment * Update with correct exercise heading * Update with correct exercise number * rename troubleshooting to addNumbers * Rename script to numberChecker * Rename math to mathEquations * Give undefined assignment to undeclared variables instead of null * Add solution * Add tests for the solution * rename follow to joinStrings * Improve hint * Add additional hint * Update exercise title to mathEquations * Move explanation for enabling tests to numberChecker exercise * Renumber repeatString * Renumber reverseString * Renumber removeFromArray * Renumber sumAll * Renumber leapYears * Renumber tempConversion * Renumber calculator * Renumber palindromes * Renumber fibonacci * Renumber getTheTitles * Renumber findTheOldest * Remove unnecessary mention of file name * Use bullet point for extended description of a step * Remove redundant snippet of comment already in the code * Use bullet points for extended descriptions of steps * Use syntax highlighting for code snippet * Clarify which file will be edited * Remove period * Add final instruction * Update reference to exercise file names * Remove unnecessary comment from solution * Add comment as reminder to not edit some of the code * Separate tests for steps two and three * Remove unnecessary comment from solution * Update wording * Remove additional space after periods
Stale numbering - missed TheOdinProject#509
* Add empty files to create outline * Add broken troubleshooting function * Import troubleshooting.js file * Test function to ensure numbers are added together * Describe exercise two * Test result for troubleshooting function * Add solution * Add empty files to create outline * Add broken numberChecker function * Export numberChecker function * Verify proper return value for numbers greater than or equal to ten * Verify proper return value for numbers less than ten * Add solution * Skip tests after the first one * Describe exercise three * Add empty files to create outline * Add math variables for the exercise * Verify that math-related variables are returning correct answers * Add solution * Add tests for solution * Describe exercise * Add comment to describe answer already given * Add empty files to create outline * Add example problem * Verify that example problem contains correct variables * Add boilerplate code required to begin exercise * Add progressive tests for exercise * Describe exercise * Adjust excessive indentation * Add hint using comment * Update with correct exercise heading * Update with correct exercise number * rename troubleshooting to addNumbers * Rename script to numberChecker * Rename math to mathEquations * Give undefined assignment to undeclared variables instead of null * Add solution * Add tests for the solution * rename follow to joinStrings * Improve hint * Add additional hint * Update exercise title to mathEquations * Move explanation for enabling tests to numberChecker exercise * Renumber repeatString * Renumber reverseString * Renumber removeFromArray * Renumber sumAll * Renumber leapYears * Renumber tempConversion * Renumber calculator * Renumber palindromes * Renumber fibonacci * Renumber getTheTitles * Renumber findTheOldest * Remove unnecessary mention of file name * Use bullet point for extended description of a step * Remove redundant snippet of comment already in the code * Use bullet points for extended descriptions of steps * Use syntax highlighting for code snippet * Clarify which file will be edited * Remove period * Add final instruction * Update reference to exercise file names * Remove unnecessary comment from solution * Add comment as reminder to not edit some of the code * Separate tests for steps two and three * Remove unnecessary comment from solution * Update wording * Remove additional space after periods
Stale numbering - missed TheOdinProject#509
Stale numbering - missed TheOdinProject/javascript-exercises#509
Because
we are removing Replit completely from the curriculum, so we need to replace the four exercises from Replit.
This PR
01_helloWorld's README to account for these new exercises.skipping tests fromrepeatStringexercise to the (new)numberCheckerexercisenumberCheckeris now the first exercise in which tests are.skippedIssue
Related to TheOdinProject/curriculum#29054
Additional Information
Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once:
Blockers:
curriculumrepo to replace the Replit lessons currently there - JavaScript Basics Course: Replace Replit exercises curriculum#29161I will link the relevant PRs here in a moment after I create them.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder