Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

fix test session finish with duplicated tests in suite#105

Merged
pupssman merged 3 commits intoallure-framework:masterfrom
tbicr:master
Nov 21, 2016
Merged

fix test session finish with duplicated tests in suite#105
pupssman merged 3 commits intoallure-framework:masterfrom
tbicr:master

Conversation

@tbicr
Copy link

@tbicr tbicr commented Nov 18, 2016

For example fix situation when we repeat failed tests.
In this case tests and refined_tests have different size that will raise exception for tests[::-1] assignment.

fix test session finish with duplicated tests in suite
1372dec 
For example fix situation when we repeat failed tests.
@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

Makes sense. Plz fix integration test run -- AFAICS, they fail due to new checks in pep8

@tbicr
Copy link
Author

tbicr commented Nov 21, 2016

@pupssman , I a bit confused, look like pep8 broken in master. Should I fix it in this commit or you can check that master already pass pep8?

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

It would be great for you to fix pep8 issues currently present in master.

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

Also, while you are here why not to look at #102 to earn lots of community karma points? Everybody strives for #101

@tbicr
Copy link
Author

tbicr commented Nov 21, 2016

@pupssman , CI works too strange, added blank line broke tests for python2.7, flake8>=3.0.0 not support python2.6

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

Wow, looks like a bug in CI config. Looks like we should not run flake8 per each environment, only once, with latest python.
Also, strange that memory consumption test failed.

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

Sadly, I dont have much time to look into it now

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

That does the job!

https://travis-ci.org/allure-framework/allure-python/jobs/177651437

GLOB sdist-make: /home/travis/build/allure-framework/allure-python/setup.py
py26 create: /home/travis/build/allure-framework/allure-python/.tox/py26
py26 installdeps: pytest, pytest-cov, pytest-xdist, pyhamcrest
py26 inst: /home/travis/build/allure-framework/allure-python/.tox/dist/pytest-allure-adaptor-1.7.5.zip
py26 installed: DEPRECATION: Python 2.6 is no longer supported by the Python core team, please upgrade your Python. A future version of pip will drop support for Python 2.6,apipkg==1.4,argparse==1.4.0,coverage==4.2,enum34==1.1.6,execnet==1.4.1,lxml==3.6.4,namedlist==1.7,py==1.4.31,PyHamcrest==1.9.0,pytest==2.9.0,pytest-allure-adaptor==1.7.5,pytest-cov==2.4.0,pytest-xdist==1.15.0,six==1.10.0
py26 runtests: PYTHONHASHSEED='2418803278'
py26 runtests: commands[0] | coverage run --source=allure -m py.test tests/ --basetemp=/home/travis/build/allure-framework/allure-python/.tox/py26/tmp
============================= test session starts ==============================
platform linux3 -- Python 2.6.9, pytest-2.9.0, py-1.4.31, pluggy-0.3.1
rootdir: /home/travis/build/allure-framework/allure-python, inifile: 
plugins: allure-adaptor-1.7.5, xdist-1.15.0, cov-2.4.0
collected 252 items 
tests/test_attach.py ............................
tests/test_common.py ....

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

LGTM
@mavlyutov plz take a look too

@mavlyutov
Copy link
Contributor

mavlyutov commented Nov 21, 2016

looks good, thanks for contributing!

@pupssman pupssman merged commit b26150c into allure-framework:master Nov 21, 2016
@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

@tbicr do you need that released soon?

@tbicr
Copy link
Author

tbicr commented Nov 21, 2016

@pupssman , for me easily use pypi version instead github commit in requirements, so if you can make minor release it will be great!

@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

@tbicr will try 2 do it today

@pupssman pupssman mentioned this pull request Nov 21, 2016
Merged
@pupssman
Copy link
Contributor

pupssman commented Nov 21, 2016

@tbicr here ya go: https://pypi.python.org/pypi/pytest-allure-adaptor/1.7.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbicr @pupssman @mavlyutov