[FragmentStrictMode] Detect wrong Fragment container usage#146
Closed
simonschiller wants to merge 1 commit intoandroidx:androidx-mainfrom
Closed
[FragmentStrictMode] Detect wrong Fragment container usage#146simonschiller wants to merge 1 commit intoandroidx:androidx-mainfrom
simonschiller wants to merge 1 commit intoandroidx:androidx-mainfrom
Conversation
8fbe22e to
23a24fc
Compare
23a24fc to
cd84de8
Compare
jbw0033
approved these changes
Mar 29, 2021
jbw0033
left a comment
There was a problem hiding this comment.
Thank you for doing all of these. We are ready to make the APIs public now. Do you want to a change for removing the RestrictTo() annotations?
Contributor
Author
|
Happy to help 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fragmentcontainers other thanFragmentContainerViewTesting
Test: See
FragmentStrictModeTest#detectWrongFragmentContainerIssues Fixed
Fixes: 181137036