Skip to content

Convert java.lang.Integer to kotlin.Int#493

Closed
veyndan wants to merge 1 commit intoandroidx:androidx-mainfrom
veyndan:270612487/integer-to-int
Closed

Convert java.lang.Integer to kotlin.Int#493
veyndan wants to merge 1 commit intoandroidx:androidx-mainfrom
veyndan:270612487/integer-to-int

Conversation

@veyndan
Copy link
Contributor

@veyndan veyndan commented Feb 28, 2023 •
edited by dlam
Loading

Proposed Changes

  • Convert java.lang.Integer to kotlin.Int.

Test: ./gradlew test connectedCheck
Bug: 270612487

@dlam dlam requested a review from claraf3 February 28, 2023 16:55
@veyndan
Copy link
Contributor Author

veyndan commented Mar 1, 2023

The CI failure seems unrelated to my changes.

After seeing that many steps are retrieved from the cache, and that the file paging-common-3.2.0-alpha05.jar doesn't exist (presumably it should be created by one of those cached steps), perhaps the cache is corrupted?

> Task :paging:integration-tests:testapp:preBuild UP-TO-DATE
> Task :paging:integration-tests:testapp:preReleaseBuild UP-TO-DATE
> Task :paging:integration-tests:testapp:mergeReleaseJniLibFolders FROM-CACHE
> Task :paging:integration-tests:testapp:checkReleaseDuplicateClasses
> Task :paging:integration-tests:testapp:buildKotlinToolingMetadata
> Task :paging:integration-tests:testapp:checkReleaseAarMetadata
> Task :paging:integration-tests:testapp:mapReleaseSourceSetPaths
> Task :paging:integration-tests:testapp:generateReleaseResources UP-TO-DATE
> Task :paging:integration-tests:testapp:mergeReleaseResources FROM-CACHE
> Task :paging:integration-tests:testapp:packageReleaseResources FROM-CACHE
> Task :paging:integration-tests:testapp:parseReleaseLocalResources FROM-CACHE
> Task :paging:integration-tests:testapp:createReleaseCompatibleScreenManifests
> Task :paging:paging-runtime:extractDeepLinksRelease FROM-CACHE
> Task :paging:paging-rxjava2:extractDeepLinksRelease FROM-CACHE
> Task :paging:integration-tests:testapp:extractDeepLinksRelease FROM-CACHE
> Task :paging:integration-tests:testapp:processReleaseMainManifest FROM-CACHE
> Task :paging:integration-tests:testapp:processReleaseManifest FROM-CACHE
> Task :paging:integration-tests:testapp:processReleaseManifestForPackage FROM-CACHE
> Task :paging:integration-tests:testapp:processReleaseResources FROM-CACHE
> Task :paging:integration-tests:testapp:javaPreCompileRelease FROM-CACHE
> Task :paging:integration-tests:testapp:desugarReleaseFileDependencies FROM-CACHE
> Task :paging:integration-tests:testapp:mergeExtDexRelease FAILED
> Task :paging:paging-common:compileKotlin

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':paging:integration-tests:testapp:mergeExtDexRelease'.
> Could not resolve all files for configuration ':paging:integration-tests:testapp:releaseRuntimeClasspath'.
   > Failed to transform room-paging-2.6.0-SNAPSHOT.aar (androidx.room:room-paging:2.6.0-SNAPSHOT:20230216.035043-1) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-enable-jacoco-instrumentation=false, dexing-is-debuggable=false, dexing-min-sdk=14, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=integration, org.gradle.usage=java-runtime}.
      > Could not resolve all files for configuration ':paging:integration-tests:testapp:releaseRuntimeClasspath'.
         > Failed to transform paging-common.jar (project :paging:paging-common) to match attributes {artifactType=android-classes-jar, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.environment=standard-jvm, org.gradle.jvm.version=8, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
            > Execution failed for IdentityTransform: /home/runner/work/androidx/androidx/out/paging-playground/paging-playground/paging/paging-common/build/libs/paging-common-3.2.0-alpha05.jar.
               > File/directory does not exist: /home/runner/work/androidx/androidx/out/paging-playground/paging-playground/paging/paging-common/build/libs/paging-common-3.2.0-alpha05.jar

After running the above commands locally, I can confirm that it passed and that androidx/out/paging-playground/paging-playground/paging/paging-common/build/libs/paging-common-3.2.0-alpha05.jar exists.

@claraf3
Copy link
Member

claraf3 commented Mar 1, 2023 •
edited
Loading

Thanks for investigating! I will take care of this from my end.

@copybara-service copybara-service bot closed this in 2d9dfa8 Mar 3, 2023
@veyndan veyndan deleted the 270612487/integer-to-int branch March 3, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianhanniballake ianhanniballake ianhanniballake approved these changes

@dlam dlam dlam approved these changes

@claraf3 claraf3 claraf3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veyndan @claraf3 @ianhanniballake @dlam