Skip to content

Remove unncessary delay in test #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veyndan wants to merge 1 commit into from
Closed

Remove unncessary delay in test #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions paging/paging-common/src/test/kotlin/androidx/paging/CachingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.Job
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancelAndJoin
import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.catch
import kotlinx.coroutines.flow.filterIsInstance
Expand Down Expand Up @@ -221,10 +220,7 @@ class CachingTest {
assertThat(tracker.pageEventFlowCount()).isEqualTo(0)
assertThat(tracker.pageDataFlowCount()).isEqualTo(0)
val items = runBlocking {
pageFlow.collectItemsUntilSize(9) {
// see http://b/146676984
delay(10)
}
pageFlow.collectItemsUntilSize(9)
}
val firstList = buildItems(
version = 0,
Expand All @@ -234,10 +230,7 @@ class CachingTest {
)
assertThat(tracker.pageDataFlowCount()).isEqualTo(1)
val items2 = runBlocking {
pageFlow.collectItemsUntilSize(21) {
// see http://b/146676984
delay(10)
}
pageFlow.collectItemsUntilSize(21)
}
assertThat(items2).isEqualTo(
buildItems(
Expand Down Expand Up @@ -401,7 +394,6 @@ class CachingTest {

private suspend fun Flow<PagingData<Item>>.collectItemsUntilSize(
expectedSize: Int,
onEach: (suspend () -> Unit)? = null
): List<Item> {
return this
.mapLatest { pagingData ->
Expand All @@ -411,9 +403,6 @@ class CachingTest {
val receiver = pagingData.hintReceiver
var loadedPageCount = 0
pagingData.flow.filterIsInstance<PageEvent.Insert<Item>>()
.onEach {
onEach?.invoke()
}
.onEach {
items.addAll(
it.pages.flatMap {
Expand Down