app/controllers/api/migrations.php (1)

453-457: Remove duplicate setProject() in CSV import trigger.

setProject() is invoked twice in a row; likely a copy/paste artifact. If you intended to pass other context (e.g., platform/user), replace the duplicate with the missing call.

Suggested tweak

         $queueForMigrations
             ->setMigration($migration)
             ->setProject($project)
-            ->setProject($project)
             ->trigger();

app/http.php (1)

184-184: $pools parameter is unused in createDatabase.

PHPMD already flagged this; consider removing the parameter and adjusting call sites.

Suggested change (update call sites accordingly)

-function createDatabase(Http $app, string $resourceKey, string $dbName, array $collections, mixed $pools, callable $extraSetup = null): void
+function createDatabase(Http $app, string $resourceKey, string $dbName, array $collections, callable $extraSetup = null): void

app/controllers/general.php (1)

63-63: Remove unused $utopia parameter from router() and call sites.

PHPMD flags this as an unused parameter. Dropping it reduces noise without changing behavior.

♻️ Proposed update

-function router(Http $utopia, Database $dbForPlatform, callable $getProjectDB, SwooleRequest $swooleRequest, Request $request, Response $response, Log $log, Event $queueForEvents, StatsUsage $queueForStatsUsage, Func $queueForFunctions, Executor $executor, Reader $geodb, callable $isResourceBlocked, array $platform, string $previewHostname, Authorization $authorization, ?Key $apiKey, DeleteEvent $queueForDeletes, int $executionsRetentionCount)
+function router(Database $dbForPlatform, callable $getProjectDB, SwooleRequest $swooleRequest, Request $request, Response $response, Log $log, Event $queueForEvents, StatsUsage $queueForStatsUsage, Func $queueForFunctions, Executor $executor, Reader $geodb, callable $isResourceBlocked, array $platform, string $previewHostname, Authorization $authorization, ?Key $apiKey, DeleteEvent $queueForDeletes, int $executionsRetentionCount)
 {
     ...
 }

-            if (router($utopia, $dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
+            if (router($dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
                 $utopia->getRoute()?->label('router', true);
             }

-        if (router($utopia, $dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
+        if (router($dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
             $utopia->getRoute()?->label('router', true);
         }

-            if (router($utopia, $dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
+            if (router($dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
                 $utopia->getRoute()?->label('router', true);
             }

-            if (router($utopia, $dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
+            if (router($dbForPlatform, $getProjectDB, $swooleRequest, $request, $response, $log, $queueForEvents, $queueForStatsUsage, $queueForFunctions, $executor, $geodb, $isResourceBlocked, $platform, $previewHostname, $authorization, $apiKey, $queueForDeletes, $executionsRetentionCount)) {
                 $utopia->getRoute()?->label('router', true);
             }

Also applies to: 898-902, 1189-1193, 1582-1584, 1617-1619

app/init/resources.php (2)

1207-1209: Suspicious unused parameter in plan resource callback.

The $plan parameter in the callback signature has a default value and is never used - the function always returns an empty array. This parameter appears to be dead code. If $plan is meant to be injected from another resource, it should be listed in the dependencies array (the third parameter to setResource).

-Http::setResource('plan', function (array $plan = []) {
+Http::setResource('plan', function () {
     return [];
 });

---

86-87: Global variable pattern for register initialization is systematic and intentional.

The global $register; usage is part of an established bootstrap pattern used consistently across all entry points (app/init/resources.php, app/cli.php, app/worker.php, etc.) where the globally-initialized registry is immediately exposed through each system's resource container. While the global keyword creates a temporary dependency during bootstrap, the register is properly registered as a resource rather than left as an implicit dependency throughout the application.

If future refactoring removes the global bootstrap pattern entirely in favor of pure dependency injection at the initialization layer, this global usage would be eliminated naturally.

app/controllers/general.php (1)

63-63: Remove or use unused $utopia parameter in router.
Line 63: $utopia isn’t referenced in the function body, which matches the static analysis warning. If not required, drop it and update call sites.