Fix gh pr view crash with fine-grained PATs (#12597)#12653
Open
VishnuVV27 wants to merge 1 commit intocli:trunkfrom
Open
Fix gh pr view crash with fine-grained PATs (#12597)#12653VishnuVV27 wants to merge 1 commit intocli:trunkfrom
VishnuVV27 wants to merge 1 commit intocli:trunkfrom
Conversation
|
Thank you for your pull request! 🎉 This PR appears to fix the following issues that are not labeled with
help wanted
As outlined in our Contributing Guidelines, we expect that PRs are only created for issues that have been labeled While we appreciate your initiative, please note that:
What happens next:
Thank you for your understanding and contribution to the project! 🙏 This comment was automatically generated by cliAutomation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash in
gh pr view(and related commands usingFinder.Find) when the user's authentication token does not have permission to access status checks/statuses. This is a common issue for users with "Fine-Grained" Personal Access Tokens on organization-owned private repositories.Fix
statusCheckRollupfield out of the initial GraphQL query and into a parallel background fetch within finder.go.api.IsGraphQLErrorResourceNotAccessibleto detect permission-related GraphQL failures. If the background fetch for status checks fails because of lack of permissions, the error is now ignored rather than aborting the entire command. This allows the user to see the PR title, body, and comments even if they can't see the check results.Verification
FORBIDDENerror for thestatusCheckRollupfield. Confirmed that without the fix, the test crashes, and with the fix, the command successfully returns the PR data.pkg/cmd/pr/view/...to ensure standard users (with full permissions) still see check results as intended. All 39 tests passed.Checklist
Fixes #12597