Draft
Conversation
Add greppable TODO identifiers above all if-statements that reference featuredetection struct fields, as required by the featuredetection linter. This ensures every feature detection branch is tagged for future cleanup when GHES gains support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a go/analysis-based linter that checks if-statements referencing featuredetection struct fields (IssueFeatures, PullRequestFeatures, RepositoryFeatures, SearchFeatures, ReleaseFeatures) have a `// TODO <identifier>` comment within 10 lines above. Feature detection code branches behavior between GHES and github.com, and becomes dead code when GHES gains support. The named TODO tag provides a greppable identifier so all related code can be found and cleaned up when the time comes. Usage: go run ./pkg/linter/featuredetection/cmd/featuredetection-lint ./... Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
go/analysis-based linter that requires// TODO <identifier>comments aboveif-statements referencing featuredetection struct fields. This ensures feature detection branches are tagged for cleanup when GHES gains support.The linter checks for a matching TODO comment within the 10 lines above each flagged
if-statement. It runs standalone viago run ./pkg/linter/featuredetection/cmd/featuredetection-lint ./...and is added as a CI step in.github/workflows/lint.yml.