Use pre-compiled regexp for matching Content-Type#12781
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes gh api response handling by pre-compiling the JSON Content-Type matcher used in processResponse, avoiding repeated regexp compilation per response.
Changes:
- Add a package-level pre-compiled regexp for matching JSON
Content-Typevalues. - Switch
processResponsefromregexp.MatchStringto(*regexp.Regexp).MatchString.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2b037ef to
6057bfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-compile the Content-Type regex used in
processResponseto avoidrecompiling it on processing API response each time.