Fix help-wanted label name mismatch in PR triage workflow#12809
Closed
Fix help-wanted label name mismatch in PR triage workflow#12809
Conversation
The shared triage-pr-requirements workflow defaults help_wanted_label to 'help-wanted' (hyphenated), but the actual repo label is 'help wanted' (with a space). This caused grep -qx exact matching to always fail, incorrectly flagging every external PR as not meeting requirements. Pass the correct label name explicitly to both check-requirements and close-unmet-requirements jobs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR triage GitHub Actions workflow to pass the repository’s actual “help wanted” label name (space-separated) into the shared triage-pr-requirements reusable workflow, fixing an exact-match label check that previously never matched.
Changes:
- Pass
help_wanted_label: 'help wanted'to thecheck-requirementsjob. - Pass
help_wanted_label: 'help wanted'to the scheduledclose-unmet-requirementsjob.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Actually, I think this should be fixed upstream: desktop/gh-cli-and-desktop-shared-workflows#7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared
triage-pr-requirementsworkflow defaultshelp_wanted_labeltohelp-wanted(hyphenated), but the actual repo label ishelp wanted(with a space). Thegrep -qxexact match never matched, so every external PR was incorrectly flagged as not meeting requirements.This fix passes the correct label name explicitly to both
check-requirementsandclose-unmet-requirementsjobs.Ref: #12803 (comment)