Add driver field to top-level secret object#1783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
- Coverage 56.31% 56.27% -0.05%
==========================================
Files 308 308
Lines 21391 21416 +25
==========================================
+ Hits 12047 12051 +4
- Misses 8465 8482 +17
- Partials 879 883 +4 |
|
I see a similar miniscule reduction in code coverage in the analogous PR #1746, so I hope that is not going to block this PR from being accepted. |
thaJeztah
left a comment
There was a problem hiding this comment.
Had a quick look at the changes, and left some comments 🤗
7975b45 to
357c438
Compare
|
@thaJeztah I have rebased and squashed as requested, PTAL. |
|
ping @silvin-lubecki @vdemeester perhaps you could have a look as well? 🤗 |
|
note this will conflict with #1781 (which is targeted for 19.03), this will have to be rebased, and the bindata will have to be re-generated after that is merged |
I'll stand by to rebase and regenerate bindata once that is merged. |
Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
357c438 to
ed838bf
Compare
|
@thaJeztah Since #1781 is not merged yet, I assume the regenerating of bindata will happen in that PR? |
|
Spoke with @dperny and he's ok doing a rebase/regenerate of the spec, so let's merge 🎉 |
- What I did
Added support for specifying a driver for a secret in a compose file when performing a
docker stack deploy.- How I did it
Added a
driverfield to theFileObjectConfigin cli/compose/types/types.go.- How to verify it
make -f docker.Makefile binaryand run the repro case in #1782.- Description for the changelog
Added support for secret drivers in docker stack deploy
- A picture of a cute animal (not mandatory but encouraged)
