Codecov Report

Merging #4156 (88be16c) into master (60d0659) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4156   +/-   ##
=======================================
  Coverage   58.86%   58.87%           
=======================================
  Files         572      572           
  Lines       49544    49556   +12     
=======================================
+ Hits        29162    29174   +12     
  Misses      18616    18616           
  Partials     1766     1766           

Thanks! This should probably be fine, but before we merge, I want to do a quick check look; ISTR we discussed some of this, and whether or not to add this "as-is", have a "porcelain" option (for runtime annotations), etc. (But it's been some time, so I need to read up / read back on some of that).

Thanks! This should probably be fine, but before we merge, I want to do a quick check look; ISTR we discussed some of this, and whether or not to add this "as-is", have a "porcelain" option (for runtime annotations), etc. (But it's been some time, so I need to read up / read back on some of that).

This feature has been already implemented in podman run --annotation, so my opinion is to just follow their CLI design so that their users can easily adopt docker run --annotation too

@thaJeztah Can we merge this?

We discussed this in the maintainers meeting, and generally are ok with the current implementation. There were some concerns;

• Is "annotation" confusing (vs "label")? We could probably borrow some of the wording from https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/ to explain the differences
• Is it clear enough this is passed through to the runtime? We discussed describing it as "stored on the container, and passed through to the OCI runtime"
• We discussed the = being optional; we don't expect these to (like --env) ever take values from the environment, and that to be ambiguous, so we're good with that (easier to use)
• We do want @oyabun to have a quick look before merging.

Thanks!