Swarm cluster and node TLS info in CLI#44
Swarm cluster and node TLS info in CLI#44aaronlehmann merged 1 commit intodocker:masterfrom cyli:root-ca-info-in-cli
Conversation
|
Needs a rebase already |
|
The docs for these changes is moby/moby#33148. Also going to reference the CA rotation docs https://github.com/cyli/docker/blob/6c847f8c437906fa26686c5167801ae48a010348/docs/reference/commandline/swarm_ca.md (from moby/moby#33152), since there was some discussion in moby/moby#32875 (comment) about whether to include the TLS info by default if there is a root rotation in progress, and https://github.com/cyli/docker/blob/6c847f8c437906fa26686c5167801ae48a010348/docs/reference/commandline/swarm_ca.md#--rotate better documents why that column could be useful (could also be added later on). |
responses to the CLI. In `node ls`, display only whether the nodes' TLS info matches the cluster's TLS info, or whether the node needs cert rotation. Signed-off-by: Ying Li <ying.li@docker.com>
|
cc @cpuguy83 @aaronlehmann - these were the CLI changes from moby/moby#32875 before. It no longer has the conditional column, and https://github.com/cyli/docker/blob/6c847f8c437906fa26686c5167801ae48a010348/docs/reference/commandline/swarm_ca.md#--rotate gives an example of how to display the TLS status when in the middle of a root rotation. I don't feel super strongly, but it might be convenient to just automatically show that when there is a root rotation, though. On the other hand, maybe next version we should just provide a filter in swarmkit to show all the nodes that are stuck? |
|
LGTM |
[cherry-pick] Enable client side digest pinning for stack deploy
Propagate the swarm cluster and node TLS info provided by the REST API
responses to the CLI. In
node ls, display only whether the nodes' TLSinfo matches the cluster's TLS info, or whether the node needs cert rotation.
Signed-off-by: Ying Li ying.li@docker.com
This code was originally in moby/moby#32875.
Sample output: