Add support for read_only services in stack deploy#73
Merged
dnephin merged 1 commit intodocker:masterfrom May 11, 2017
Merged
Conversation
thaJeztah
approved these changes
May 11, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
apparenty it was already in the compose-file schema 😅
dnephin
suggested changes
May 11, 2017
Contributor
dnephin
left a comment
There was a problem hiding this comment.
You'll need to remove it from UnsupportedProperties in cli/compose/types/types.go as well. I guess the tests are still passing because it's just printing a warning.
The `read_only` key in a composefile is not taken into account right now. Now that services support `--read-only`, so should `stack deploy` Ref: moby/moby#32994 Signed-off-by: Vincent Demeester <vincent@sbr.pm>
e5fac26 to
0ab760a
Compare
Collaborator
Author
|
@dnephin updated 👼 |
Contributor
|
LGTM |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Update changelog for 17.06.0-ce RC5
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Remove Ubuntu Zesty Upstream-commit: f8f8219caef8a92c6c87b92377d476af44d76b7c Component: packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
read_onlykey in a composefile is not taken into account rightnow. Now that services support
--read-only, so shouldstack deployRef: moby/moby#32994
🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm