This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] Fix stderr logging for journald and syslog#95
Merged
andrewhsu merged 1 commit intodocker-archive:17.06from Jul 12, 2017
andrewhsu:fix-logging
Merged
[17.06] Fix stderr logging for journald and syslog#95andrewhsu merged 1 commit intodocker-archive:17.06from andrewhsu:fix-logging
andrewhsu merged 1 commit intodocker-archive:17.06from
andrewhsu:fix-logging
Conversation
thaJeztah
approved these changes
Jul 4, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
ping @tiborvass @cpuguy83
logger.PutMessage, added in #28762 (v17.04.0-ce), clears msg.Source. So journald and syslog were treating stderr messages as if they were stdout. Signed-off-by: David Glasser <glasser@davidglasser.net> (cherry picked from commit 917050c) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
3 tasks
docker-jenkins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Don't append number when doing a dev build Upstream-commit: 468d37e Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 25, 2018
[18.09] Add note that we use the bump_v18.09 branch for SwarmKit Upstream-commit: 78746ca9e8cc46304509866ab34851f56b4a7edb Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Don't append number when doing a dev build
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.06] Fix stderr logging for journald and syslog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix:
With cherry-pick moby/moby@917050c:
No conflicts.