This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] progress: Show progress of replicated tasks before they are assigned#97
Merged
andrewhsu merged 1 commit intodocker-archive:17.06from Jul 11, 2017
andrewhsu:fix-progress
Merged
[17.06] progress: Show progress of replicated tasks before they are assigned#97andrewhsu merged 1 commit intodocker-archive:17.06from andrewhsu:fix-progress
andrewhsu merged 1 commit intodocker-archive:17.06from
andrewhsu:fix-progress
Conversation
This was only showing tasks that belong to nodes that are currently up, so that tasks on down nodes don't appear to be stuck. But this unintentionally excludes tasks that haven't been assigned yet, so if a task is stuck before assignment, for example because no nodes meet its constraints, a progress bar won't even be shown. The check should only apply to tasks that have a node assignment. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> (cherry picked from commit d3d09f67b18673ec457c5f6634d346a937c58728) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
|
LGTM |
Member
|
@andrewhsu looks ready to merge |
docker-jenkins
pushed a commit
that referenced
this pull request
Mar 29, 2018
Add building code for Ubuntu Bionic (18.04) LTS Upstream-commit: f2312f5 Component: packaging
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
[17.06] progress: Show progress of replicated tasks before they are assigned
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Add building code for Ubuntu Bionic (18.04) LTS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix: