Merged
Conversation
It targets an old pre v1.0 alpha version of containerd and is not currently maintained. closes moby#2219, closes moby#2258, closes moby#2259 and closes moby#2299. The vendoring of libtrust did not become obsolete here but vndr noted that it was unused so I dropped it while I was there. Signed-off-by: Ian Campbell <ijc@docker.com>
1cc057c to
fe9b063
Compare
Contributor
Author
|
I don't think this can be my changes: Flakey test? |
Contributor
|
@ijc yes, I have a PR to remove the environment variable so we can test without setting a glibal end var, which causes issues when tests are run in parallel |
Contributor
Author
Contributor
|
@ijc It is - it might take a while, since that's based on some other PRs. I'll just rebuild for now. |
Collaborator
|
LGTM when it passes tests. Thanks for cleaning up after yourself. |
cyli
approved these changes
Mar 23, 2018
Contributor
cyli
left a comment
There was a problem hiding this comment.
LGTM on tests passing. Hooray for code removal!
Codecov Report
@@ Coverage Diff @@
## master #2568 +/- ##
==========================================
+ Coverage 61.46% 61.77% +0.31%
==========================================
Files 134 134
Lines 21800 21800
==========================================
+ Hits 13399 13468 +69
+ Misses 6958 6886 -72
- Partials 1443 1446 +3 |
Contributor
Author
|
Thanks for shepherding it through the tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It targets an old pre v1.0 alpha version of containerd and is not currently
maintained.
closes #2219, closes #2258, closes #2259 and closes #2299.
The vendoring of libtrust did not become obsolete here but vndr noted that it
was unused so I dropped it while I was there.
Signed-off-by: Ian Campbell ijc@docker.com