This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] middleware: Redact secret data on "secret create"#99
Merged
andrewhsu merged 1 commit intodocker-archive:17.06from Jul 12, 2017
andrewhsu:redact
Merged
[17.06] middleware: Redact secret data on "secret create"#99andrewhsu merged 1 commit intodocker-archive:17.06from andrewhsu:redact
andrewhsu merged 1 commit intodocker-archive:17.06from
andrewhsu:redact
Conversation
With debug logging turned on, we currently log the base64-encoded secret payload. Change the middleware code to redact this. Since the field is called "Data", it requires some context-sensitivity. The URI path is examined to see which route is being invoked. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> (cherry picked from commit 3fbc352) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
thaJeztah
approved these changes
Jul 12, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
ping @cyli @aaronlehmann
Contributor
|
This looks correct to me, and matches what's currently in |
thaJeztah
pushed a commit
to thaJeztah/docker-ce
that referenced
this pull request
Apr 3, 2018
Add Ubuntu 18.04 arm64 builds Upstream-commit: bad901e Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 31, 2018
[18.09] cluster: set bigger grpc limit for array requests Upstream-commit: fb51c760c4fed545a83a6b6f88716e5d6bb8b1f0 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Add Ubuntu 18.04 arm64 builds
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.06] middleware: Redact secret data on "secret create"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix:
With cherry-pick moby/moby@3fbc352:
No conflicts.