Skip to content

Add sha256sum template function#90

Merged
tianon merged 1 commit intodocker-library:masterfrom
infosiftr:sha256sum
Jan 22, 2024
Merged

Add sha256sum template function#90
tianon merged 1 commit intodocker-library:masterfrom
infosiftr:sha256sum

Conversation

@tianon
Copy link
Member

@tianon tianon commented Jan 20, 2024

This is intentionally named and implemented to match the one in Sprig: https://masterminds.github.io/sprig/crypto.html

I need this so that docker-library/meta-scripts#16 can calculate sourceIds in pure bashbrew formatting (and thus be really fast): 😅

...
	{{- $sum := $.ArchGitChecksum $a . -}}
	{{- $file := .ArchFile $a -}}
	{{- $builder := .ArchBuilder $a -}}
	{
		"sourceId": {{ join "\n" $sum $file $builder "" | sha256sum | json }},
		"reproducibleGitChecksum": {{ $sum | json }},
...

@tianon
Add sha256sum template function
1a4c6e8 
This is intentionally named and implemented to match the one in Sprig: https://masterminds.github.io/sprig/crypto.html
@tianon tianon requested a review from yosifkit as a code owner January 20, 2024 00:45
This was referenced Jan 20, 2024
Merged
Closed
yosifkit
yosifkit reviewed Jan 20, 2024
View reviewed changes
pkg/templatelib/lib.go
}),

// {{- sha256sum "hello world" -}}
"sha256sum": func(input string) string {
Copy link
Member

@yosifkit yosifkit Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test for this?

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0b38175) 75.21% compared to head (1a4c6e8) 74.89%.

Files Patch % Lines
pkg/templatelib/lib.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   75.21%   74.89%   -0.33%     
==========================================
  Files           8        8              
  Lines         920      924       +4     
==========================================
  Hits          692      692              
- Misses        173      177       +4     
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianon tianon merged commit bc4c23b into docker-library:master Jan 22, 2024
@tianon tianon deleted the sha256sum branch January 22, 2024 17:43
@tianon
Copy link
Member Author

tianon commented Jan 22, 2024 •
edited
Loading

Gah, forgot to refresh.

Edit: #91

@tianon tianon mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tianon @codecov-commenter @yosifkit