[azure monitor] Add latency config option by zmoog · Pull Request #44366 · elastic/beats

zmoog · 2025-05-19T06:55:51Z

Proposed commit message

Add a new latency configuration option to the Azure Monitor metricset.

Latency is the time it takes for the Azure service to publish the metric
values to Azure Monitor. The metricset uses the latency value to
compensate for the delay in metric value publishing.

Default value is 0. Typical values are 30s or 1m.

  |                                                        |
  |                                                        |             Now
  |                                                        │              |
  |                                            time grain  │              |
  │                                          │◀──(PT1M)──▶ │              |
  │                                                        │              |
  ├──────────────────────────────────────────┼─────────────┼──────────────|
  │                                                        │              |
  │                       timespan           │             │              |
  |◀───────────────────────(5min)─────────────────────────▶│              |
  │                                          │             │              |
  |                        period                          │              |
  │◀───────────────────────(5min)─────────────────────────▶|              │
  │                                                        │              |
  │                                                        │              |
  |                                                        │   latency    |
  |                                                        | ◀──(1min)──▶ |
  │                                                        │              |
  │                                                        │              |
Start                                                     End             |
  │                                                        │              |

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

How to test this PR locally

Related issues

Closes Add latency in Azure resource metrics integrations #44356

github-actions · 2025-05-19T06:56:02Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2025-05-19T06:56:28Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zmoog? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

x-pack/metricbeat/module/azure/client_test.go

x-pack/metricbeat/module/azure/config.go

x-pack/metricbeat/module/azure/client.go

x-pack/metricbeat/module/azure/client_test.go

`positive` is more expressive.

elasticmachine · 2025-05-19T10:47:21Z

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

Eliminates the code duplication to calculate start/end of the metric values timespan in batch and non-batch versions of getting metric values.

MichaelKatsoulis

Looks perfect!

mergify · 2025-05-19T15:03:32Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b zmoog/feat/azure-monitor-latency upstream/zmoog/feat/azure-monitor-latency
git merge upstream/main
git push upstream zmoog/feat/azure-monitor-latency

This makes file the build, I'm not sure if/how we beed to update docs using asciidoc format, or if we should use markdown instead.

github-actions · 2025-05-20T08:32:52Z

@Mergifyio backport 8.17 8.18 8.19 9.0

mergify · 2025-05-20T08:33:19Z

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details

#44393 [8.17](backport #44366) [azure monitor] Add latency config option has been created for branch 8.17
#44394 [8.18](backport #44366) [azure monitor] Add latency config option has been created for branch 8.18
#44395 [8.19](backport #44366) [azure monitor] Add latency config option has been created for branch 8.19
#44396 [9.0](backport #44366) [azure monitor] Add latency config option has been created for branch 9.0

Add a new `latency` configuration option to the Azure Monitor metricset. Latency is the time it takes for the Azure service to publish the metric values to Azure Monitor. The metricset uses the `latency` value to compensate for the delay in metric value publishing. Default value is `0`. Typical values are `30s` or `1m`. ```text | | | | Now | │ | | time grain │ | │ │◀──(PT1M)──▶ │ | │ │ | ├──────────────────────────────────────────┼─────────────┼──────────────| │ │ | │ timespan │ │ | |◀───────────────────────(5min)─────────────────────────▶│ | │ │ │ | | period │ | │◀───────────────────────(5min)─────────────────────────▶| │ │ │ | │ │ | | │ latency | | | ◀──(1min)──▶ | │ │ | │ │ | Start End | │ │ | ``` (cherry picked from commit 2921bbe)

Add a new `latency` configuration option to the Azure Monitor metricset. Latency is the time it takes for the Azure service to publish the metric values to Azure Monitor. The metricset uses the `latency` value to compensate for the delay in metric value publishing. Default value is `0`. Typical values are `30s` or `1m`. ```text | | | | Now | │ | | time grain │ | │ │◀──(PT1M)──▶ │ | │ │ | ├──────────────────────────────────────────┼─────────────┼──────────────| │ │ | │ timespan │ │ | |◀───────────────────────(5min)─────────────────────────▶│ | │ │ │ | | period │ | │◀───────────────────────(5min)─────────────────────────▶| │ │ │ | │ │ | | │ latency | | | ◀──(1min)──▶ | │ │ | │ │ | Start End | │ │ | ``` (cherry picked from commit 2921bbe) Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

Add latency config option

2790869

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 19, 2025

mergify bot assigned zmoog May 19, 2025

zmoog mentioned this pull request May 19, 2025

Add latency in Azure resource metrics integrations #44356

Closed

zmoog changed the title ~~Add latency config option~~ [azure monitor] Add latency config option May 19, 2025