Conversation
|
The PR is blocked because of the issue : #10400 |
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
packages/aws/data_stream/awshealth/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
| name: cloud.account.id | ||
| dimension: true | ||
| - external: ecs | ||
| name: cloud.region |
There was a problem hiding this comment.
Please follow the ecs@mappings template.
There was a problem hiding this comment.
Removed non-dimension fields from ecs.yml file
|
The metrics include the |
zmoog
left a comment
There was a problem hiding this comment.
@agithomas, should we also set up the .github/CODEOWNERS file for this integration?
This already exists. Snippet from the screenshot. The metrics are broken down into Status & Regionwise.
|
…gs, regenerated sample_events
Thanks for pointing it out. Added the entry. |
shmsr
left a comment
There was a problem hiding this comment.
Also, see this patch:
Makes small adjustments to make all descriptions consistent.
diff --git a/packages/aws/data_stream/awshealth/fields/fields.yml b/packages/aws/data_stream/awshealth/fields/fields.yml
index 14795aa42..260f40da1 100644
--- a/packages/aws/data_stream/awshealth/fields/fields.yml
+++ b/packages/aws/data_stream/awshealth/fields/fields.yml
@@ -4,7 +4,7 @@
- name: awshealth
type: group
description: >
- AWS Health metrics
+ AWS Health metrics.
fields:
- name: affected_entities_others
type: float
@@ -33,12 +33,12 @@
type: keyword
dimension: true
description: >
- The unique identifier for the event. The event ARN has the format `arn:aws:health:<event-region>::event/<SERVICE>/<EVENT_TYPE_CODE>/<EVENT_TYPE_PLUS_ID>`. For example, `arn:aws:health:us-east-1::event/EC2/EC2_INSTANCE_RETIREMENT_SCHEDULED/EC2_INSTANCE_RETIREMENT_SCHEDULED_ABC123-DEF456`
+ The unique identifier for the event. The event ARN has the format `arn:aws:health:<event-region>::event/<SERVICE>/<EVENT_TYPE_CODE>/<EVENT_TYPE_PLUS_ID>`. For example, `arn:aws:health:us-east-1::event/EC2/EC2_INSTANCE_RETIREMENT_SCHEDULED/EC2_INSTANCE_RETIREMENT_SCHEDULED_ABC123-DEF456`.
- name: event_scope_code
type: keyword
description: >
- This parameter specifies whether the Health event is a public Amazon Web Service event or an account-specific event. Allowed values are `PUBLIC`, `ACCOUNT_SPECIFIC`, or `NONE`."
+ The parameter that specifies whether the Health event is a public Amazon Web Service event or an account-specific event. Allowed values are `PUBLIC`, `ACCOUNT_SPECIFIC`, or `NONE`.
- name: event_type_category
type: keyword
@@ -85,7 +85,7 @@
object_type: keyword
object_type_mapping_type: "*"
description: >
- Details of the affected entities related to the event.
+ The details of the affected entities related to the event.
- name: affected_entities.aws_account_id
type: keyword
@@ -105,7 +105,7 @@
- name: affected_entities.last_updated_time
type: date
description: >
- The last updated time of entity.
+ The last updated time of the entity.
- name: affected_entities.status_code
type: keywordI have a couple of suggestions for package-fields.yml but from our earlier discussion, you want to keep it as it in data_streams for consistency; so skipping those nitpicks.
| multi: true | ||
| required: false | ||
| show_user: true | ||
| - name: tags_filter |
There was a problem hiding this comment.
Add description for tags_filter, region, period and data_granularity.
|
Just a couple of comments. Rest looks good; ready to approve when these comments get addressed. |
Addressed the suggestions. |
zmoog
left a comment
There was a problem hiding this comment.
LGTM!
I only left a comment to remind us that we may need to revisit the definitions of the data_stream.* and @timestamp fields in the future.
| - name: data_stream.type | ||
| type: constant_keyword | ||
| description: Data stream type. | ||
| - name: data_stream.dataset | ||
| type: constant_keyword | ||
| description: Data stream dataset. | ||
| - name: data_stream.namespace | ||
| type: constant_keyword | ||
| description: Data stream namespace. | ||
| - name: '@timestamp' | ||
| type: date | ||
| description: Event timestamp. |
There was a problem hiding this comment.
IIRC, ECS includes definitions for the data_stream.* and @timestamp fields, so we may not need to include these ones.
Base
https://www.elastic.co/guide/en/ecs/current/ecs-base.html
Data Stream
https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html
However, I just noticed that elastic-package explicitly checks for these fields, so removing them is not an option until we update elastic-package.
I'll leave this comment as a reminder we may need to remove these field definitions in the future.
|
💚 Build Succeeded
History
|
|
Package aws - 2.18.0 containing this change is available at https://epr.elastic.co/search?package=aws |
Type of change
Proposed commit message
Create AWS Health Integration.
AWS health metrics provide insights into the health of your AWS environment by monitoring various aspects, such as open issues, scheduled maintenance events, etc.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots