Skip to content

Create Azure resource metrics package#1021

Merged
narph merged 24 commits intoelastic:masterfrom
narph:azure-metrics
Jul 26, 2021
Merged

Create Azure resource metrics package#1021
narph merged 24 commits intoelastic:masterfrom
narph:azure-metrics

Conversation

@narph
Copy link
Contributor

@narph narph commented May 26, 2021 •
edited
Loading

What does this PR do?

Create Azure resource metrics package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented May 26, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-26T14:15:06.104+0000

  • Duration: 10 min 10 sec

  • Commit: d2fcf88

Test stats 🧪

Test Results
Failed 0
Passed 80
Skipped 0
Total 80

Trends 🧪

Image of Build Times

Image of Tests

@narph narph self-assigned this May 31, 2021
@narph narph changed the title POC - Granularity Azure package Create Azure resource metrics package Jun 1, 2021
@narph narph mentioned this pull request Jun 1, 2021
Closed
8 tasks
@narph narph added the Team:Platforms Label for the Integrations - Platforms team label Jun 2, 2021
@elasticmachine
Copy link

elasticmachine commented Jun 2, 2021

Pinging @elastic/integrations (Team:Platforms)

mtojek
mtojek reviewed Jul 22, 2021
View reviewed changes
packages/azure_metrics/data_stream/compute_vm/fields/ecs.yml
@@ -0,0 +1,92 @@
- name: ecs.version
Copy link
Contributor

@mtojek mtojek Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use dependency management (new feature) to import all ECS fields? docs

@mtojek mtojek mentioned this pull request Jul 26, 2021
Closed
@mtojek mtojek self-requested a review July 26, 2021 14:44
mtojek
mtojek approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in and add more changes in iterations.

@narph narph merged commit 9263824 into elastic:master Jul 26, 2021
@narph narph deleted the azure-metrics branch July 26, 2021 14:47
@andrewkroh andrewkroh added Integration:azure_metrics Azure Resource Metrics New Integration Issue or pull request for creating a new integration package. and removed Integration:azure Azure Logs labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@narph narph

Labels

7.14 candidate Integration:azure_metrics Azure Resource Metrics New Integration Issue or pull request for creating a new integration package. Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add azure metrics package

4 participants

@narph @elasticmachine @mtojek @andrewkroh