Skip to content

azure metrics: add list of supported databases and namespaces#11118

Merged
zmoog merged 2 commits intoelastic:mainfrom
zmoog:zmoog/azure-database-accounts-docs
Sep 19, 2024
Merged

azure metrics: add list of supported databases and namespaces#11118
zmoog merged 2 commits intoelastic:mainfrom
zmoog:zmoog/azure-database-accounts-docs

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Sep 12, 2024

Proposed commit message

Add the list of databases and namespaces supported by the Azure Database Account integration.

Set the right expectations about the namespaces and supported databases. Without this list, users may expect this integration to support all database types available in Azure.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@zmoog zmoog requested a review from a team as a code owner September 12, 2024 16:36
@zmoog zmoog self-assigned this Sep 12, 2024
@zmoog zmoog added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:azure_metrics Azure Resource Metrics Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Sep 12, 2024
@andrewkroh andrewkroh added the enhancement New feature or request label Sep 12, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

Package azure_metrics 👍(0) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
compute_vm 200000 100000 -100000 (-50%) 💔
compute_vm_scaleset 250000 142857.14 -107142.86 (-42.86%) 💔
container_service 250000 200000 -50000 (-20%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @zmoog

@elastic-sonarqube
Copy link

@muthu-mps
Copy link
Contributor

@zmoog - Just a question around the integration name, Can we rename this integration to Azure Cosmos DB if it is appropriate. Because this is the right name I can find in the Azure services. WDYT?

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muthu-mps
Copy link
Contributor

@zmoog - Just a question around the integration name, Can we rename this integration to Azure Cosmos DB if it is appropriate. Because this is the right name I can find in the Azure services. WDYT?

We can take this separately.

@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

@zmoog - Just a question around the integration name, Can we rename this integration to Azure Cosmos DB if it is appropriate. Because this is the right name I can find in the Azure services. WDYT?

We can take this separately.

Good point.

I'm opening a dedicated issue to discuss this topic! I need to do some research.

@zmoog zmoog merged commit 076cfec into elastic:main Sep 19, 2024
@zmoog zmoog deleted the zmoog/azure-database-accounts-docs branch September 19, 2024 08:29
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…c#11118)

Add the list of databases and namespaces supported by the Azure Database Account integration.

Set the right expectations about the namespaces and supported databases. Without this list, users may expect this integration to support all database types available in Azure.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…c#11118)

Add the list of databases and namespaces supported by the Azure Database Account integration.

Set the right expectations about the namespaces and supported databases. Without this list, users may expect this integration to support all database types available in Azure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:azure_metrics Azure Resource Metrics Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants