Skip to content

[azure/graphactivitylogs] fix destination.geo.region_name mapping#11749

Merged
kaiyan-sheng merged 0 commit intoelastic:mainfrom
kaiyan-sheng:azure_region_name
Nov 22, 2024
Merged

[azure/graphactivitylogs] fix destination.geo.region_name mapping#11749
kaiyan-sheng merged 0 commit intoelastic:mainfrom
kaiyan-sheng:azure_region_name

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 14, 2024

Proposed commit message

This PR is to add destination.geo.region_name mapping into ecs.yml to fix error:

object mapping for [destination.geo.region_name] tried to parse field 
[region_name] as object, but found a concrete value\"}, dropping event!"

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from zmoog November 14, 2024 18:29
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review November 14, 2024 18:30
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners November 14, 2024 18:30
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 14, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 18, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kaiyan-sheng
Copy link
Contributor Author

/test

@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #18453 failed c8ab7f61d8e9b6300c37a637167566e990d924f0
  • 💔 Build #18450 failed c8ab7f61d8e9b6300c37a637167566e990d924f0
  • 💚 Build #18354 succeeded d0a233512ae5341d29d5444d67a4194687697314

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code owner approval.

@kaiyan-sheng kaiyan-sheng enabled auto-merge (squash) November 21, 2024 15:04
@kaiyan-sheng
Copy link
Contributor Author

Hi @elastic/security-service-integrations , could I get a review on this PR please? Thanks!

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 9e4ff10 into elastic:main Nov 22, 2024
@elastic-vault-github-plugin-prod

Package azure - 1.19.4 containing this change is available at https://epr.elastic.co/package/azure/1.19.4/

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@kaiyan-sheng kaiyan-sheng deleted the azure_region_name branch February 7, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants