Skip to content

[Cloud Security] add external id field#12329

Merged
Omolola-Akinleye merged 0 commit intoelastic:mainfrom
Omolola-Akinleye:add-external-id-field
Jan 17, 2025
Merged

[Cloud Security] add external id field#12329
Omolola-Akinleye merged 0 commit intoelastic:mainfrom
Omolola-Akinleye:add-external-id-field

Conversation

@Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented Jan 13, 2025 •
edited
Loading

Proposed commit message

I'm adding external_id input var field for the cloudbeat/cis_aws input. We will use Role ARN and External ID fields
to establish trust with Elastic.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related ticket: Add Cloud Connector Support for Agentless CSPM AWS Integration

@Omolola-Akinleye Omolola-Akinleye added enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] 8.18 candidate labels Jan 13, 2025
@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner January 13, 2025 01:24
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jan 13, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 13, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

moukoublen
moukoublen reviewed Jan 14, 2025
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
Copy link
Member

@moukoublen moukoublen Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since the 1.12.0 was released, we might need to create a new release 1.13.0-preview01, wdyt?

And if we create a 1.13 preview release then we might need to also add:

The new version in manifest.
(example: https://github.com/elastic/integrations/pull/11663/files#diff-72fc27a4cf2fb28244c8fa9ed27c00e43935777a4875c5d61d91372f0d483425L4)

The new elk stack version as a condition.
(example: https://github.com/elastic/integrations/pull/11663/files#diff-72fc27a4cf2fb28244c8fa9ed27c00e43935777a4875c5d61d91372f0d483425L14)

Copy link
Contributor Author

@Omolola-Akinleye Omolola-Akinleye Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh thank you!

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jan 17, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

elasticmachine commented Jan 17, 2025

💚 Build Succeeded

History

  • 💚 Build #20398 succeeded 1bde0523c845efb512fe1cca5a9cdb0becc20b76
  • 💚 Build #20320 succeeded d58e9713df6dd1d419a36076012130c6f77cf0e9

@Omolola-Akinleye Omolola-Akinleye merged commit 503d301 into elastic:main Jan 17, 2025
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 17, 2025

Package cloud_security_posture - 1.13.0-preview01 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0-preview01/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@Omolola-Akinleye
[Cloud Security] add external id field (elastic#12329)
50e4cd5 
* add external id field

* update changelog for external id

* update the configuration correctly

* fix configuration

* fix yaml logic
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@Omolola-Akinleye
[Cloud Security] add external id field (elastic#12329)
77f07e4 
* add external id field

* update changelog for external id

* update the configuration correctly

* fix configuration

* fix yaml logic
@Omolola-Akinleye Omolola-Akinleye deleted the add-external-id-field branch February 10, 2025 09:56
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package cloud_security_posture - 1.13.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0/

@andrewkroh andrewkroh removed the Integration:cloud_security_posture Security Posture Management label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moukoublen moukoublen moukoublen approved these changes

Assignees

No one assigned

Labels

8.18 candidate enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Omolola-Akinleye @elasticmachine @moukoublen @andrewkroh