Skip to content

[Cloud Security] add required_vars validation rules and default CSPM and Asset Inventory to agentless deployment#12363

Merged
seanrathier merged 0 commit intoelastic:mainfrom
seanrathier:required-fields
Jan 27, 2025
Merged

[Cloud Security] add required_vars validation rules and default CSPM and Asset Inventory to agentless deployment#12363
seanrathier merged 0 commit intoelastic:mainfrom
seanrathier:required-fields

Conversation

@seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Jan 15, 2025 •
edited
Loading

Proposed commit message

required_vars validation rules for CSPM integration and default agentless deployments.

Add required_vars validation rules for CSPM integration for conditionally required fields.
Defaulting CSPM and Asset Inventory to agentless deployments.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • package-spec version 3.3.2 released

How to test this PR locally

Related issues

Screenshots

Screenshot 2025-01-23 at 12 34 13 PM

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jan 15, 2025
@seanrathier seanrathier changed the title [Cloud Security] added required_vars [Cloud Security] [Bug] Require Agentless CSPM account fields' to be mandatory and editable options Jan 21, 2025
@seanrathier seanrathier mentioned this pull request Jan 23, 2025
Closed
5 tasks
@seanrathier seanrathier changed the title [Cloud Security] [Bug] Require Agentless CSPM account fields' to be mandatory and editable options [Cloud Security] add required_vars validation rules and default to agentless deployment Jan 23, 2025
@andrewkroh andrewkroh added the Integration:cloud_asset_inventory Cloud Asset Discovery label Jan 23, 2025
@seanrathier seanrathier added the enhancement New feature or request label Jan 23, 2025
@seanrathier seanrathier marked this pull request as ready for review January 23, 2025 17:34
@seanrathier seanrathier requested a review from a team as a code owner January 23, 2025 17:34
@andrewkroh andrewkroh added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jan 23, 2025
@seanrathier seanrathier self-assigned this Jan 23, 2025
@seanrathier seanrathier mentioned this pull request Jan 23, 2025
Merged
2 tasks
@seanrathier seanrathier changed the title [Cloud Security] add required_vars validation rules and default to agentless deployment [Cloud Security] add required_vars validation rules and default CSPM and Asset Inventory to agentless deployment Jan 23, 2025
opauloh
opauloh approved these changes Jan 23, 2025
View reviewed changes
packages/cloud_asset_inventory/manifest.yml Outdated
Comment on lines 48 to 94
Copy link
Contributor

@opauloh opauloh Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was that an IDE auto-formatting?

Copy link
Contributor Author

@seanrathier seanrathier Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. I ran the elastic-package build lint on it. That may have changed it.

@Omolola-Akinleye Omolola-Akinleye self-requested a review January 24, 2025 17:48
Omolola-Akinleye
Omolola-Akinleye previously requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Role_ARN showing in AWS CSPM UI for Manual selection. Sorry for the confusion.

@Omolola-Akinleye Omolola-Akinleye dismissed their stale review January 24, 2025 19:04

Manual form has Assume Role

This was referenced Jan 26, 2025
Merged
Closed
@seanrathier
Copy link
Contributor Author

seanrathier commented Jan 27, 2025

/test

@elastic elastic deleted a comment from elasticmachine Jan 27, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 27, 2025

🚀 Benchmarks report

Package cloud_security_posture 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
findings 52631.58 43478.26 -9153.32 (-17.39%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jan 27, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

elasticmachine commented Jan 27, 2025

💚 Build Succeeded

History

  • 💔 Build #21007 failed 9c8cc3edc2fe314365222b5e8d8145802e4fe773

cc @seanrathier

@seanrathier seanrathier merged this pull request into elastic:main Jan 27, 2025
4 of 5 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 27, 2025

Package cloud_asset_inventory - 0.8.0 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/0.8.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 27, 2025

Package cloud_security_posture - 1.13.0-preview02 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0-preview02/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@seanrathier
[Cloud Security] add required_vars validation rules and default CSPM …
d31a5d6 
…and Asset Inventory to agentless deployment (elastic#12363)
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@seanrathier
[Cloud Security] add required_vars validation rules and default CSPM …
4c59d13 
…and Asset Inventory to agentless deployment (elastic#12363)
@seanrathier seanrathier deleted the required-fields branch February 6, 2025 22:46
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package cloud_security_posture - 1.13.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0/

@andrewkroh andrewkroh removed Integration:cloud_security_posture Security Posture Management Integration:cloud_asset_inventory Cloud Asset Discovery labels Mar 13, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 7, 2025

Package cloud_asset_inventory - 0.9.0 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/0.9.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 30, 2025

Package cloud_asset_inventory - 0.10.0 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/0.10.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opauloh opauloh opauloh approved these changes

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye left review comments

Assignees

@seanrathier seanrathier

Labels

enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seanrathier @elasticmachine @Omolola-Akinleye @opauloh @andrewkroh