Skip to content

Inital PR for WMI Input Package#12654

Merged
ishleenk17 merged 17 commits intoelastic:mainfrom
ishleenk17:wmi_input
Aug 20, 2025
Merged

Inital PR for WMI Input Package#12654
ishleenk17 merged 17 commits intoelastic:mainfrom
ishleenk17:wmi_input

Conversation

@ishleenk17
Copy link
Member

@ishleenk17 ishleenk17 commented Feb 7, 2025 •
edited
Loading

Proposed commit message

WMI Input Package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@ishleenk17 ishleenk17 self-assigned this Feb 7, 2025
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Feb 14, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Mar 13, 2025
@botelastic
Copy link

botelastic bot commented Apr 12, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 12, 2025
@botelastic
Copy link

botelastic bot commented May 12, 2025

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this May 12, 2025
@ishleenk17 ishleenk17 reopened this Jul 10, 2025
@botelastic botelastic bot removed the Stalled label Jul 10, 2025
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 10, 2025
@ishleenk17 ishleenk17 requested a review from a team July 17, 2025 10:30
@ishleenk17 ishleenk17 marked this pull request as ready for review July 17, 2025 10:30
@ishleenk17 ishleenk17 requested a review from a team as a code owner July 17, 2025 10:30
@herrBez
Copy link
Contributor

herrBez commented Aug 6, 2025

Hi @ishleenk17 , any news?

@ishleenk17
Copy link
Member Author

ishleenk17 commented Aug 6, 2025

Hi @ishleenk17 , any news?

@herrBez :Apologies, this completely skipped our radar.
Are we just waiting for review ? Are there any open questions ?
Looks like CI is passing.

@herrBez
Copy link
Contributor

herrBez commented Aug 6, 2025 •
edited
Loading

From my side, I think the only open questions are:

  • [Optional/We can ingore it for now] is why Metricbeat is not reporting null values in the final object, in other words the option wmi.include_null_properties has no effect (but this is more a problem of Metricbeat than for the integration)

  • [Optional/We can ignore it for now] Whether we want to use the Windows Icon instead of the Elastic Icon for the package

  • If the documentation is enough for this first draft version

@ishleenk17
Copy link
Member Author

ishleenk17 commented Aug 6, 2025 •
edited
Loading

From my side, I think the only open questions are:

  • [Optional/We can ingore it for now] is why Metricbeat is not reporting null values in the final object, in other words the option wmi.include_null_properties has no effect (but this is more a problem of Metricbeat than for the integration)

Yes, this looks like an issue for metricbeat. Lets raise an issue there.

  • [Optional/We can ignore it for now] Whether we want to use the Windows Icon instead of the Elastic Icon for the package

The logo is windows icon as I can see. The screesnhot can be removed completely as we don't have any dashbaord for input packages.

  • If the documentation is enough for this first draft version

I'll take a look, Will also include doc team to review this

@elasticmachine
Copy link

elasticmachine commented Aug 6, 2025

💚 Build Succeeded

History

cc @herrBez @ishleenk17

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 6, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@stefans-elastic
Copy link
Contributor

stefans-elastic commented Aug 18, 2025

Test Env

OS: Windows Server 2022
Stack version: 8.19.1

Test Results

Test Case Status Notes
Basic Connectivity ✅
WMI Metricset ✅
No errors ✅
Agent remains in HEALTHY state ✅

Screenshot

Image

@ishleenk17 ishleenk17 merged commit 8d9b117 into elastic:main Aug 20, 2025
8 of 9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 20, 2025

Package wmi - 0.0.1 containing this change is available at https://epr.elastic.co/package/wmi/0.0.1/

@andrewkroh andrewkroh added the Integration:wmi Custom WMI Input Package label Aug 20, 2025
@herrBez herrBez mentioned this pull request Sep 17, 2025
Merged
5 tasks
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@ishleenk17 @herrBez
Inital PR for WMI Input Package (elastic#12654)
5a42981 
* Inital PR for WMI Input Package

* Add codeowners

* TMoving config options under wmi object

* Update namespace

* Fix typo in the configuration

* Fix errors

* Update windows logo

* Add more config options for WMI

* Add additional params to the manifest

* Add/Update properties

* Add the first draft of the README

* Update all properties, add the custom category, add custom to the title

* Make sure requirements are stated before configuration

* Fix broken links

* Remove dummy screenshot

---------

Co-authored-by: Mirko Bez <mirko.bez@elastic.co>
Co-authored-by: Mirko Bez <herrBez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@stefans-elastic stefans-elastic stefans-elastic approved these changes

Assignees

@herrBez herrBez

@ishleenk17 ishleenk17

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:wmi Custom WMI Input Package New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ishleenk17 @herrBez @elasticmachine @stefans-elastic @jsoriano @muthu-mps @andrewkroh