Skip to content

[Cloud Security] Fix GCP Organization Agentless validation#13048

Merged
seanrathier merged 2 commits intoelastic:mainfrom
seanrathier:gcp-oprg-agentless-validation
Mar 11, 2025
Merged

[Cloud Security] Fix GCP Organization Agentless validation#13048
seanrathier merged 2 commits intoelastic:mainfrom
seanrathier:gcp-oprg-agentless-validation

Conversation

@seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Mar 10, 2025 •
edited
Loading

Proposed commit message

Removed the validation requiring a project ID for CSPM GCP integration when the account type is organization

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Start Kibana

  1. Load CSPM integration with the preview mode on (cloud_security_posture-1.13.0-preview05)
  2. Select GCP
  3. Select Organization account
  4. Select Agentless
  5. Enter the Organization ID
  6. Enter the JSON Blob
  7. Save button should be enabled

Related issues

closes https://github.com/elastic/security-team/issues/12087

Screenshots

Screen.Recording.2025-03-10.at.5.16.56.PM.mov

@seanrathier seanrathier self-assigned this Mar 10, 2025
@seanrathier seanrathier added Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] bug Something isn't working, use only for issues labels Mar 10, 2025
@seanrathier seanrathier marked this pull request as ready for review March 10, 2025 21:18
@seanrathier seanrathier requested a review from a team as a code owner March 10, 2025 21:19
@seanrathier seanrathier changed the title Fix GCP Organization Agentless validation [Cloud Security] Fix GCP Organization Agentless validation Mar 10, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 10, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2025

💚 Build Succeeded

cc @seanrathier

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Mar 10, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@seanrathier seanrathier merged commit 6e515eb into elastic:main Mar 11, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package cloud_security_posture - 1.13.0-preview05 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0-preview05/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 11, 2025

Package cloud_security_posture - 1.13.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0/

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Mar 13, 2025
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@seanrathier @flexitrev
[Cloud Security] Fix GCP Organization Agentless validation (#13048)
6591ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye approved these changes

Assignees

@seanrathier seanrathier

Labels

bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seanrathier @elasticmachine @Omolola-Akinleye @andrewkroh