Add enable_batch_api option in azure resource metrics#13783
Add enable_batch_api option in azure resource metrics#13783zmoog merged 3 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
container_service |
200000 | 142857.14 | -57142.86 (-28.57%) | 💔 |
To see the full report comment with /test benchmark fullreport
| - name: enable_batch_api | ||
| type: bool | ||
| title: Enable Batch Api | ||
| description: > | ||
| When enabled, the azure batch api will be used | ||
| to fetch metrics of multiple resources in one api call. | ||
| Enable this when facing scalability issues. | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: false |
There was a problem hiding this comment.
nits: minor capitalization suggestions.
| - name: enable_batch_api | |
| type: bool | |
| title: Enable Batch Api | |
| description: > | |
| When enabled, the azure batch api will be used | |
| to fetch metrics of multiple resources in one api call. | |
| Enable this when facing scalability issues. | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: false | |
| - name: enable_batch_api | |
| type: bool | |
| title: Enable Batch API | |
| description: > | |
| When enabled, the Azure batch API will be used | |
| to fetch metrics of multiple resources in one API call. | |
| Enable this when facing scalability issues. | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: false |
| `Enable Batch Api` _boolean_ | ||
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the azure batch api will be used | ||
| to fetch metrics of multiple resources in one api call. | ||
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | ||
|
|
There was a problem hiding this comment.
nit:
| `Enable Batch Api` _boolean_ | |
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the azure batch api will be used | |
| to fetch metrics of multiple resources in one api call. | |
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | |
| `Enable Batch API` _boolean_ | |
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the Azure batch API will be used | |
| to fetch metrics of multiple resources in one API call. | |
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | |
packages/azure_metrics/manifest.yml
Outdated
| conditions: | ||
| kibana: | ||
| version: "^8.12.0 || ^9.0.0" | ||
| version: "^9.0.1" |
There was a problem hiding this comment.
This is only partially related to the changes in this PR.
Is it worth backporting the Beats PR to one or more 8.x versions? Possible candidates: 8.17, 8.18, 8.19.
The reason is practical. We will support the last 8.x series (8.19.x?) for a while, as we're still doing for 7.17.x today—to deliver fixes and small improvements.
It's better to do it now than later, while the memory of the changes in the PR is still relatively fresh. We can merge this PR now, and add 8.x compatibility conditions later when the backport(s) is/are merged.
There was a problem hiding this comment.
@MichaelKatsoulis, I updated the kibana.version to match the upcoming 8.x releases supporting the batch API.
We can merge this PR when the next 8.17.7 and 8.18.2 releases become available.
There was a problem hiding this comment.
If we wait for that long then it won't be available for 9.0.1 until May 27th.
I guess we can live with that, although I don't see any reason we should not merge it now.
We now support stack 8.17.7, 8.18.2, and later.
|
💚 Build Succeeded
History
cc @zmoog |
|
Package azure_metrics - 1.8.0 containing this change is available at https://epr.elastic.co/package/azure_metrics/1.8.0/ |
Follow-up of beats PR
Proposed commit message
enable_batch_apiconfiguration parameter in azure resource metrics.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
It can be easily tested by installing Azure Resource Metrics. Enable the
enable_batch_apiadvanced setting.Then the metrics will be collected from the azure batch api.
Related issues
Screenshots