[Nvidia_GPU] Nvidia GPU Integration Enhancements#14081
[Nvidia_GPU] Nvidia GPU Integration Enhancements#14081Linu-Elias merged 17 commits intoelastic:mainfrom
Conversation
4817e6a to
8e1956c
Compare
|
Kindly handle not to display the Errors when the details of Bios Version is not avaiable. |
packages/nvidia_gpu/data_stream/stats/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The description of the dashboard says "The following dashboard provides insights into the following". To remove the repetition of the word following replace with "The Overview dashboard provides insights into the following"
There was a problem hiding this comment.
Is this a second dashboard (via link panel)? If so I can't see the. name of the dashboard. We should update the screenshot. I assume this is the dashboard named "GPU-level Metrics", as per the previous screenshot?
There was a problem hiding this comment.
Also in the "Brand name" widget, what values would we show there? It seems like a widget where we'd show a number but a brand name sounds like it will a string. Can you give an example for brand name value?
There was a problem hiding this comment.
This section displays labels in general. It includes the version, model name, brand name, last gathered date, and the number of GPUs monitored. The brand name is most likely a string, similar to the model name.
There was a problem hiding this comment.
Replace "Error count" with "Errors"
There was a problem hiding this comment.
Do we want to show screenshots of dashboard sections with empty widgets?
daniela-elastic
left a comment
There was a problem hiding this comment.
Left feedback, please address before merging. Conditionally approved
There was a problem hiding this comment.
Could you re-check if it is good to remove these mappings; instead, they may be important dimensions to be included.
There was a problem hiding this comment.
The fields are provided as labels, so we have not removed the mappings. Instead, we have mapped them using labels.* which includes all GPU labels.
I understand that we will need to update this and implement individual mappings during the TSDB enablement process. I am currently making the necessary changes while working on this task.
💚 Build Succeeded
History
cc @Linu-Elias |
|
@daniela-elastic, I have addressed all the comments and made the changes accordingly. |
|
Package nvidia_gpu - 0.2.0 containing this change is available at https://epr.elastic.co/package/nvidia_gpu/0.2.0/ |




Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots
3.