Improve documentation by avoiding redirecting to Metricbeat Metricset by herrBez · Pull Request #15369 · elastic/integrations

herrBez · 2025-09-17T10:33:25Z

Proposed commit message

Improve Custom WMI Input Package documentation

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

[ ]

Related issues

Screenshots

stefans-elastic

just a few questions

packages/wmi/docs/README.md

stefans-elastic

LGTM

ishleenk17 · 2025-09-25T06:53:33Z

No changelog required here @herrBez ?

ishleenk17

1 comment. README looks good!

herrBez · 2025-09-25T07:20:17Z

Should I add a changelog entry and bump the version of the integration (?)

ishleenk17 · 2025-09-25T07:22:47Z

Should I add a changelog entry and bump the version of the integration (?)

YEs we can do that

herrBez · 2025-09-25T10:29:36Z

Is there any way to have :::note::: like in the integration. I guess if it's rendered here: https://www.elastic.co/docs/reference/integrations it will be shown, but not in Kibana 😕 ...

elastic-sonarqube · 2025-09-25T11:05:18Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

… all the properties are documetned

vishaangelova

Thanks Mirko! I’ve noticed some small issues, so I’ve left some comments for your consideration.

packages/wmi/docs/README.md

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

elasticmachine · 2025-10-13T18:56:25Z

💚 Build Succeeded

Buildkite Build
Commit: 2d8288d

History

💚 Build #32597 succeeded 82aaa43
💚 Build #32581 succeeded 58c77cc
💚 Build #31976 succeeded 749986e
💚 Build #31902 succeeded c705fd1
💚 Build #31868 succeeded 53684ba
💚 Build #31547 succeeded 238fbe1

vishaangelova

LGTM 🚀

elastic-vault-github-plugin-prod · 2025-10-13T20:26:36Z

Package wmi - 0.0.2 containing this change is available at https://epr.elastic.co/package/wmi/0.0.2/

…elastic#15369) * Improve documentation by avoiding redirecting to Metricbeat Metricset * Make sure we do not cite Metricbeat and/or metricset * Bump version after documentation change * Use warning and note keyword instead of ::::note:::: * Align the documentation with the Metricbeat documentation, makes sure all the properties are documetned * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> * Update packages/wmi/docs/README.md Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com> --------- Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Improve documentation by avoiding redirecting to Metricbeat Metricset

238fbe1

herrBez requested a review from a team as a code owner September 17, 2025 10:33

andrewkroh added Integration:wmi Custom WMI Input Package documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Sep 17, 2025

stefans-elastic reviewed Sep 23, 2025

View reviewed changes

Make sure we do not cite Metricbeat and/or metricset

53684ba

herrBez requested a review from stefans-elastic September 23, 2025 17:00

stefans-elastic approved these changes Sep 24, 2025

View reviewed changes

Merge branch 'main' into wmi-doc-improve

c705fd1

ishleenk17 approved these changes Sep 25, 2025

View reviewed changes

Bump version after documentation change

749986e

herrBez and others added 3 commits October 10, 2025 07:51

Use warning and note keyword instead of ::::note::::

ccca3fb

Merge branch 'main' into wmi-doc-improve

58c77cc

Align the documentation with the Metricbeat documentation, makes sure…

82aaa43

… all the properties are documetned

vishaangelova reviewed Oct 13, 2025

View reviewed changes

herrBez and others added 9 commits October 13, 2025 20:22

Update packages/wmi/docs/README.md

cb7113e

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

fd2b257

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

5ceb896

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

98f4a70

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

1c952d9

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

93fd15a

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

3759367

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

e7a3d73

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

3987417

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

herrBez and others added 21 commits October 13, 2025 20:26

Update packages/wmi/docs/README.md

5e6b779

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

a0854cf

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

48363d0

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

26382d7

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

c37b78d

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

19e03aa

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

1267544

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

c270b48

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

edd6bb6

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

5fad477

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

4cdacec

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

eca558e

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

b5063d0

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

5267ab4

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

3250e38

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

28fb5c0

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

8c5d3b1

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

f989169

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

0aae280

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Update packages/wmi/docs/README.md

15f71fc

Co-authored-by: Visha Angelova <91186315+vishaangelova@users.noreply.github.com>

Merge branch 'main' into wmi-doc-improve

2d8288d

herrBez requested a review from vishaangelova October 13, 2025 18:35

vishaangelova approved these changes Oct 13, 2025

View reviewed changes

herrBez merged commit 18270cb into elastic:main Oct 13, 2025
7 checks passed

Conversation

herrBez commented Sep 17, 2025

Proposed commit message

Checklist

Author's Checklist

Related issues

Screenshots

Uh oh!

stefans-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stefans-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

ishleenk17 commented Sep 25, 2025

Uh oh!

ishleenk17 left a comment

Choose a reason for hiding this comment

Uh oh!

herrBez commented Sep 25, 2025

Uh oh!

ishleenk17 commented Sep 25, 2025

Uh oh!

herrBez commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elastic-sonarqube bot commented Sep 25, 2025

Quality Gate passed

Uh oh!

vishaangelova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Oct 13, 2025

💚 Build Succeeded

History

Uh oh!

vishaangelova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elastic-vault-github-plugin-prod bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

herrBez commented Sep 25, 2025 •

edited

Loading