🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@stefans-elastic - Lets keep the requestBody and responseBody field names in the same format and not necessary to convert it to snake case as renaming would lead to breaking change.

@stefans-elastic - Lets keep the requestBody and responseBody field names in the same format and not necessary to convert it to snake case as renaming would lead to breaking change.

@muthu-mps to clarify: requestBody and responseBody field names remain the same, right? and how about the nested fields? For example should it be:
option 1

"requestBody": {
      "test_data": {
          "my_test": 123
      }
  },
  "responseBody": {
      "sku_test": {
          "my_name": "Standard_LRS"
      }
  }

or
option 2

"requestBody": {
      "testData": {
          "myTest": 123
      }
  },
  "responseBody": {
      "skuTest": {
          "myName": "Standard_LRS"
      }
  }

@stefans-elastic - Lets keep the requestBody and responseBody field names in the same format and not necessary to convert it to snake case as renaming would lead to breaking change.

@muthu-mps to clarify: requestBody and responseBody field names remain the same, right? and how about the nested fields? For example should it be: option 1

"requestBody": {
      "test_data": {
          "my_test": 123
      }
  },
  "responseBody": {
      "sku_test": {
          "my_name": "Standard_LRS"
      }
  }

or option 2

"requestBody": {
      "testData": {
          "myTest": 123
      }
  },
  "responseBody": {
      "skuTest": {
          "myName": "Standard_LRS"
      }
  }

Same can be applied to nested fields as well. Converting the nested fields without converting base field would lead to naming inconsistency.

@muthu-mps the change has been implemented.

💚 Build Succeeded

• Buildkite Build
• Commit: c34748d

History

• 💚 Build #33577 succeeded 7b2396d
• 💚 Build #33076 succeeded 31e9171
• 💚 Build #32979 succeeded affdb7e
• 💚 Build #32932 succeeded 80883f3
• 💚 Build #32898 succeeded c0f2398
• 💔 Build #32896 failed 049dea7

Package azure - 1.29.0 containing this change is available at https://epr.elastic.co/package/azure/1.29.0/

Hello, just saw this update in the integration available and was checking the PR.

What is being changed here? the field azure.activitylogs.properties is mapped as flattened, so this is just parsing the json on the nested responseBody and requestBody but does not change any of the mappings, right?

@leandrojmp This ensures that the field is an object and not a string since apparently sometimes it is sent as a JSON marshaling of an object.