[azure logs] Fix sign-in logs category check#17027
Merged
Conversation
We can't assume category will not be null.
🚀 Benchmarks reportTo see the full report comment with |
The `?` seems to work when checking field access, but not when checking field access 🤔
💚 Build Succeeded
History
cc @zmoog |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Kavindu-Dodan
approved these changes
Jan 21, 2026
efd6
approved these changes
Jan 22, 2026
| value: azure.signinlogs | ||
| # Use same logic as the `signinlogs` stream that drops any document that doesn't end with `SignInLogs`. | ||
| if: 'ctx.routing?.category.endsWith("SignInLogs")' | ||
| if: 'ctx.routing?.category != null && ctx.routing?.category.endsWith("SignInLogs")' |
Contributor
There was a problem hiding this comment.
Suggested change
| if: 'ctx.routing?.category != null && ctx.routing?.category.endsWith("SignInLogs")' | |
| if: 'ctx.routing?.category != null && ctx.routing.category.endsWith("SignInLogs")' |
Contributor
Author
There was a problem hiding this comment.
Does this pipeline guarantee the routing field? It looks like it might be optional here.
Contributor
There was a problem hiding this comment.
if we remove the question mark then we would need to add ctx.routing != null in the beginning and remove all question marks.
I think we should keep it as it is in the PR now
muthu-mps
reviewed
Jan 22, 2026
| value: azure.signinlogs | ||
| # Use same logic as the `signinlogs` stream that drops any document that doesn't end with `SignInLogs`. | ||
| if: 'ctx.routing?.category.endsWith("SignInLogs")' | ||
| if: 'ctx.routing?.category != null && ctx.routing?.category.endsWith("SignInLogs")' |
Contributor
There was a problem hiding this comment.
If we are not processing the logs with no category then should we drop the event which doesn't have category?
Contributor
Author
There was a problem hiding this comment.
Um, I think we keep the log events.
Two reasons:
- Azure has been inconsistent in naming the field that contains the log category. So far we know they mostly usage
category, but also foundCategoryandCategoryValuein the wild. So I guess an suboptimal indexing is better than losing the log event. - custom routing: we recently added
routing.categoryas candidate field for custom routing, but users may want to customize the routing based on other criteria and fields. If we drop the log event in the main pipeline, it will never reach the custom pipeline.
muthu-mps
approved these changes
Jan 22, 2026
mykola-elastic
approved these changes
Jan 23, 2026
|
Package azure - 1.35.1 containing this change is available at https://epr.elastic.co/package/azure/1.35.1/ |
jakubgalecki0
pushed a commit
to jakubgalecki0/integrations
that referenced
this pull request
Feb 19, 2026
Add an explicit check on ctx.routing?.category to make sure it's not null before calling the endsWith("SignInLogs") method.
We can't assume category is always set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add an explicit check on
ctx.routing?.categoryto make sure it's not null before calling theendsWith("SignInLogs")method.We can't assume category is always set.
Checklist
changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Related issues