Fetch packages from package-storage#21
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
.gitignore
Outdated
| build | ||
| public | ||
|
|
||
| /dev/packages/storage No newline at end of file |
There was a problem hiding this comment.
Should we put it under build/packages/storage instead?
There was a problem hiding this comment.
Yes, this one doesn't need special cleaning. Fixed.
magefile.go
Outdated
| tarGz = true | ||
| publicDir = "./public" | ||
| buildDir = "./build" | ||
| storageDir = "./dev/packages/storage" |
There was a problem hiding this comment.
Leftover, not needed anymore.
|
ey folks, trying to understand the workflow here. Why is integrations repo fetching packages from storage? |
Packages served by the package-registry are stored in the package-storage. There are some of them that are internal/required like: Currently there are no simple ways of attaching more packages to the registry. I can look into possibilities and modify the registry, but changes the scope of this task a bit. |
|
One reason are the required packages but there is also a very nice side effect here. As all the existing packages are pulled in, any testing of new packages together with Kibana is what it will look like in the end. Example: Someone is working on the nginx package 1.3.2. The current version shipped is 1.3.1. 1.3.1 will be pulled in from the package-storage and 1.3.2 will be on top of it. |
This point depends on outcome of the discussion here: #15 |
ruflin
left a comment
There was a problem hiding this comment.
Change LGTM.
My understanding of this PR now:
- package-storage are checked out into
builddirectory so only change related to this is in the magefile - The diff on the alpha packages are coming from (version-)changes since this repo was created (mostly).
Changes:
mage buildto include packages from package-storagemage buildmultiple times (don't re-checkout the package-storage)remove(import recent alpha packages)dev/packages/alphaas they are in the package-storage