Skip to content

[GCP] Add missing cloud.provider field to GCP datastreams#3274

Merged
andrewkroh merged 5 commits intoelastic:mainfrom
legoguy1000:3270-gcp-provider
May 5, 2022
Merged

[GCP] Add missing cloud.provider field to GCP datastreams#3274
andrewkroh merged 5 commits intoelastic:mainfrom
legoguy1000:3270-gcp-provider

Conversation

@legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 4, 2022

What does this PR do?

Add missing cloud.provider field to GCP datastreams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested review from a team as code owners May 4, 2022 11:40
@elasticmachine
Copy link

elasticmachine commented May 4, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-05T16:24:12.681+0000

  • Duration: 18 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

efd6
efd6 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after version fix.

@elasticmachine
Copy link

elasticmachine commented May 4, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 5, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.623
Classes 100.0% (4/4) 💚 3.623
Methods 100.0% (54/54) 💚 11.716
Lines 96.213% (1118/1162) 👍 7.293
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit 8587eb8 into elastic:main May 5, 2022
@andrewkroh andrewkroh mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:gcp Google Cloud Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GCP] Log collection integrations does not set cloud.provider

4 participants

@legoguy1000 @elasticmachine @andrewkroh @efd6