Skip to content

[CSP] Update integration deployment instructions#3382

Merged
uri-weisman merged 4 commits intoelastic:mainfrom
uri-weisman:update_integration_readme
May 22, 2022
Merged

[CSP] Update integration deployment instructions#3382
uri-weisman merged 4 commits intoelastic:mainfrom
uri-weisman:update_integration_readme

Conversation

@uri-weisman
Copy link
Contributor

@uri-weisman uri-weisman commented May 19, 2022 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@uri-weisman uri-weisman added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label May 19, 2022
@elasticmachine
Copy link

elasticmachine commented May 19, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-19T14:15:21.511+0000

  • Duration: 14 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 4.021
Classes 100.0% (0/0) 💚 4.021
Methods 33.333% (1/3) 👎 -55.306
Lines 100.0% (0/0) 💚 9.305
Conditionals 100.0% (0/0) 💚

@uri-weisman
Copy link
Contributor Author

uri-weisman commented May 19, 2022

Closes elastic/cloudbeat#123

@uri-weisman uri-weisman mentioned this pull request May 19, 2022
Closed
3 tasks
tehilashn
tehilashn requested changes May 19, 2022
View reviewed changes
packages/cloud_security_posture/docs/README.md Outdated
```

Since updating the DaemonSet results with terminating the Elastic agent pods and recreating them, the Fleet > Agents page will display the terminated agents with status "Offline". No newline at end of file
Note, this integration can be added only to an Elastic agents with version 8.3 or above. No newline at end of file
Copy link

@tehilashn tehilashn May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "an" and change to higher
Note, this integration can be added only to Elastic agents with version 8.3 or higher.

@uri-weisman uri-weisman requested a review from tehilashn May 19, 2022 13:58
@uri-weisman uri-weisman marked this pull request as ready for review May 19, 2022 13:58
@uri-weisman uri-weisman requested a review from a team as a code owner May 19, 2022 13:58
@uri-weisman uri-weisman merged commit 31ef297 into elastic:main May 22, 2022
@uri-weisman uri-weisman deleted the update_integration_readme branch May 22, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tehilashn tehilashn tehilashn approved these changes

Assignees

No one assigned

Labels

Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uri-weisman @elasticmachine @tehilashn