Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
endorama
requested changes
Aug 1, 2022
packages/gcp/changelog.yml
Outdated
| - description: Add GCP Firestore Data stream | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/2704 | ||
| - description: Add GCP Storage Data Stream |
Contributor
There was a problem hiding this comment.
Please target the most recent version of this package
This reverts commit efe5ae5. Bump to 2.7.0 was correct so this PR can be merged after elastic#3493
This reverts commit 41c69fb. Bump to 2.7.0 was correct so this PR can be merged after elastic#3493
endorama
approved these changes
Aug 23, 2022
Contributor
|
/test |
Contributor
|
I cannot reproduce the failure locally, as the same check ( |
tommyers-elastic
requested changes
Aug 24, 2022
Contributor
tommyers-elastic
left a comment
There was a problem hiding this comment.
small typo in metric name
`authz.acl_based_object_access_.ount` -> `authz.acl_based_object_access_.count`
9e1a55c to
5da5bf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
storagedata stream.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots