Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
Author
|
/test |
endorama
reviewed
Sep 7, 2022
|
|
||
| The `dataproc` dataset fetches metrics from [Dataproc](https://cloud.google.com/dataproc/) in Google Cloud Platform. It contains all metrics exported from the [GCP Dataproc Monitoring API](https://cloud.google.com/monitoring/api/metrics_gcp#gcp-dataproc). | ||
|
|
||
| You can specify a single region to fetch metrics like `us-central1`. Be aware that GCP Storage does not use zones so `us-central1-a` will return nothing. If no region is specified, it will return metrics from all buckets. |
Contributor
There was a problem hiding this comment.
Is this reference to GCP storage appropriate here?
packages/gcp/changelog.yml
Outdated
| - description: Remove fields duplicated in ECS fields | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/3609 | ||
| - description: Add GCP Dataproc Data stream |
Contributor
There was a problem hiding this comment.
needs update to latest gcp package version.
endorama
reviewed
Sep 9, 2022
|
|
||
| The `dataproc` dataset fetches metrics from [Dataproc](https://cloud.google.com/dataproc/) in Google Cloud Platform. It contains all metrics exported from the [GCP Dataproc Monitoring API](https://cloud.google.com/monitoring/api/metrics_gcp#gcp-dataproc). | ||
|
|
||
| You can specify a single region to fetch metrics like `us-central1`. Be aware that GCP Dataproc does not use zones so `us-central1-a` will return nothing. If no region is specified, it will return metrics from all buckets. |
Contributor
There was a problem hiding this comment.
After reading this line, I was wondering if we can simply remove the zone configuration from the data stream. what do you think?
Suggested change
| You can specify a single region to fetch metrics like `us-central1`. Be aware that GCP Dataproc does not use zones so `us-central1-a` will return nothing. If no region is specified, it will return metrics from all buckets. | |
| You can specify a single region to fetch metrics like `us-central1`. Be aware that GCP Dataproc is a regional service. If no region is specified, it will return metrics from all buckets. |
endorama
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
dataprocdata stream.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots