Skip to content

[Azure Logs] Add recommendations for event hub configuration#3805

Merged
zmoog merged 2 commits intoelastic:mainfrom
zmoog:event-hub-recommendations
Jul 26, 2022
Merged

[Azure Logs] Add recommendations for event hub configuration#3805
zmoog merged 2 commits intoelastic:mainfrom
zmoog:event-hub-recommendations

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Jul 22, 2022 •
edited
Loading

What does this PR do?

Currently, Elastic Agent collects Azure logs running Filebeat behind the scenes. The current Filebeat implementation design requires using one event hub for each log type and today's Filebeat documentation reports that.

This PR adds the same Event Hub configuration recommendations for Azure Logs integrations.

I am adding this information because multiple people have asked this question lately.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@zmoog zmoog self-assigned this Jul 22, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:azure Azure Logs labels Jul 22, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 22, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T10:48:40.999+0000

  • Duration: 14 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 105
Skipped 0
Total 105

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 22, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 81.25% (13/16) 👎 -15.809
Classes 81.25% (13/16) 👎 -15.809
Methods 80.451% (107/133) 👎 -9.082
Lines 81.826% (1855/2267) 👎 -8.757
Conditionals 100.0% (0/0) 💚

@zmoog zmoog marked this pull request as ready for review July 22, 2022 10:59
@zmoog zmoog requested a review from a team as a code owner July 22, 2022 10:59
tommyers-elastic
tommyers-elastic approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@zmoog zmoog merged commit 49ce581 into elastic:main Jul 26, 2022
@zmoog zmoog deleted the event-hub-recommendations branch July 26, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@zmoog zmoog

Labels

enhancement New feature or request Integration:azure Azure Logs Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zmoog @elasticmachine @kaiyan-sheng @tommyers-elastic