Skip to content

Fix a typo and a bug in gcp integration package#3821

Merged
endorama merged 4 commits intomainfrom
gcp-minor-fixes
Jul 25, 2022
Merged

Fix a typo and a bug in gcp integration package#3821
endorama merged 4 commits intomainfrom
gcp-minor-fixes

Conversation

@endorama
Copy link
Contributor

@endorama endorama commented Jul 25, 2022 •
edited
Loading

What does this PR do?

While testing the gcp integration I noticed there have been a regression in the GCP Billing policy templated (incorrectly named Billine), and found a bug in the GCP Compute default period value (which was 10s when the minimum acceptable in Metricbeat is 60s; this produces an error if trying to run the default configuration).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

endorama added 3 commits July 25, 2022 10:24
@endorama
Update manifest.yml
af21382
@endorama
fix gcp period to 60s
33455a6 
60s is the minimum valid period, any number less that it creates an error when the Agent tries to run this configuration.
@endorama
Update manifest.yml
e0a3383
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 25, 2022
@endorama endorama self-assigned this Jul 25, 2022
@endorama endorama changed the title Update manifest.yml Fix a typo and a bug in gcp integration package Jul 25, 2022
@endorama endorama marked this pull request as ready for review July 25, 2022 08:37
@endorama endorama requested review from a team as code owners July 25, 2022 08:37
@elasticmachine
Copy link

elasticmachine commented Jul 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T08:33:51.394+0000

  • Duration: 20 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 25, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.901
Classes 100.0% (4/4) 💚 2.901
Methods 93.939% (62/66) 👍 4.608
Lines 95.21% (1113/1169) 👍 4.636
Conditionals 100.0% (0/0) 💚

@endorama endorama merged commit 8393374 into main Jul 25, 2022
@endorama endorama deleted the gcp-minor-fixes branch July 25, 2022 09:44
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@endorama endorama

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@endorama @elasticmachine @efd6 @tommyers-elastic