Skip to content

Removing EKS resource type rules#3973

Merged
ofiriro3 merged 3 commits intoelastic:mainfrom
ofiriro3:remove-eks-cluster-related-templates
Aug 9, 2022
Merged

Removing EKS resource type rules#3973
ofiriro3 merged 3 commits intoelastic:mainfrom
ofiriro3:remove-eks-cluster-related-templates

Conversation

@ofiriro3
Copy link
Contributor

@ofiriro3 ofiriro3 commented Aug 9, 2022 •
edited
Loading

What does this PR do?

This PR removes some of the EKS benchmark rules that are related to cluster auto-detection which we haven't implemented yet.

Explain here the changes you made on the PR.

I removed some of the EKS benchmark template rules.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ofiriro3 ofiriro3 added the bug Something isn't working, use only for issues label Aug 9, 2022
@ofiriro3 ofiriro3 requested a review from a team as a code owner August 9, 2022 09:40
@ofiriro3 ofiriro3 self-assigned this Aug 9, 2022
@ofiriro3 ofiriro3 requested a review from amirbenun August 9, 2022 09:42
@ofiriro3
Copy link
Contributor Author

ofiriro3 commented Aug 9, 2022

Rules that are using EKS resource type - >

image

ofiriro3
ofiriro3 commented Aug 9, 2022
View reviewed changes
Copy link
Contributor Author

@ofiriro3 ofiriro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

@ofiriro3 ofiriro3 changed the title Removing EKS auto-detect cluster Removing EKS resource type rules Aug 9, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-09T10:33:13.140+0000

  • Duration: 14 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

eyalkraft
eyalkraft reviewed Aug 9, 2022
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
# newer versions go on top
- version: "0.0.25"
changes:
- description: Remove unimplemented EKS rules from template
Copy link
Contributor

@eyalkraft eyalkraft Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

@elasticmachine
Copy link

elasticmachine commented Aug 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.953
Classes 100.0% (0/0) 💚 2.953
Methods 25.0% (1/4) 👎 -64.597
Lines 100.0% (0/0) 💚 8.518
Conditionals 100.0% (0/0) 💚

@ofiriro3 ofiriro3 requested review from eyalkraft and removed request for amirbenun August 9, 2022 10:49
@ofiriro3 ofiriro3 merged commit 015e88d into elastic:main Aug 9, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalkraft eyalkraft eyalkraft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ofiriro3 ofiriro3

Labels

bug Something isn't working, use only for issues Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove non-working EKS rules templates

4 participants

@ofiriro3 @elasticmachine @eyalkraft @kfirpeled