Fixes to loadbalancing_metrics datastream#3986
Merged
endorama merged 5 commits intoelastic:mainfrom Aug 12, 2022
endorama:gcp-loadlabancing-fixes
Merged
Fixes to loadbalancing_metrics datastream#3986endorama merged 5 commits intoelastic:mainfrom endorama:gcp-loadlabancing-fixes
loadbalancing_metrics datastream#3986endorama merged 5 commits intoelastic:mainfrom
endorama:gcp-loadlabancing-fixes
Conversation
Without this change collection fails with this error: ``` [constant_keyword] field [event.dataset] only accepts values that are equal to the value defined in the mappings [gcp.loadbalancing], but got [gcp.loadbalancing_metrics] ```
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
loadbalancing_metrics datastream
tommyers-elastic
approved these changes
Aug 12, 2022
Contributor
tommyers-elastic
left a comment
There was a problem hiding this comment.
apart from the changelog, LGTM
| - description: Add GCP Load Balancing Metricset | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/2308 | ||
| - description: Fix credentials_json escaping in loadbalancing_metrics |
Contributor
There was a problem hiding this comment.
some strange things going on here :)
packages/gcp/data_stream/loadbalancing_metrics/agent/stream/stream.yml.hbs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds some fixes for issues that slipped through the review of the
loadbalancing_metricsdatastream:credentials_jsonescapingChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots